SVN checkout used by RunBenchmark should be non-interactive
authordewei_zhu@apple.com <dewei_zhu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Dec 2015 01:10:55 +0000 (01:10 +0000)
committerdewei_zhu@apple.com <dewei_zhu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Dec 2015 01:10:55 +0000 (01:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=152542

Reviewed by Ryosuke Niwa.

RunBenchmark should not require user interaction while running.

* Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder._checkout_with_subversion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@194406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py

index 582c037a16d5fb4eb9bae432164db8d3e8a7eda0..bd6799ffa82d52ceb30d7c1b964a4cc3f83e43cf 100644 (file)
@@ -1,3 +1,15 @@
+2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
+
+        SVN checkout used by RunBenchmark should be non-interactive
+        https://bugs.webkit.org/show_bug.cgi?id=152542
+
+        Reviewed by Ryosuke Niwa.
+
+        RunBenchmark should not require user interaction while running.
+
+        * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
+        (BenchmarkBuilder._checkout_with_subversion):
+
 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
 
         Web Inspector: add support for running protocol-test.js tests on Windows
index 7025bfb76f1c9f75c9457b916a8a172e06df3e34..a32ec7c4eb77fb4b212f2a51aa3352399b36ae0f 100644 (file)
@@ -86,7 +86,7 @@ class BenchmarkBuilder(object):
 
     def _checkout_with_subversion(self, subversion_url):
         _log.info('Checking out %s to %s' % (subversion_url, self._dest))
-        error_code = subprocess.call(['svn', 'checkout', subversion_url, self._dest])
+        error_code = subprocess.call(['svn', 'checkout', '--trust-server-cert', '--non-interactive', subversion_url, self._dest])
         if error_code:
             raise Exception('Cannot checkout the benchmark - Error: %s' % error_code)