Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16774
REGRESSION (r27464-r27504) javascript popup menu does not display 'close' button
Test: fast/dynamic/float-no-longer-overhanging.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverhangingFloats): If a child's float turns
out not to be overhanging at this time, ensure that the child paints it.
LayoutTests:
Reviewed by Darin Adler.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=16774
REGRESSION (r27464-r27504) javascript popup menu does not display 'close' button
* fast/dynamic/float-no-longer-overhanging.html: Added.
* platform/mac/fast/dynamic/float-no-longer-overhanging-expected.checksum: Added.
* platform/mac/fast/dynamic/float-no-longer-overhanging-expected.png: Added.
* platform/mac/fast/dynamic/float-no-longer-overhanging-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2008-01-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - pixel test for http://bugs.webkit.org/show_bug.cgi?id=16774
+ REGRESSION (r27464-r27504) javascript popup menu does not display 'close' button
+
+ * fast/dynamic/float-no-longer-overhanging.html: Added.
+ * platform/mac/fast/dynamic/float-no-longer-overhanging-expected.checksum: Added.
+ * platform/mac/fast/dynamic/float-no-longer-overhanging-expected.png: Added.
+ * platform/mac/fast/dynamic/float-no-longer-overhanging-expected.txt: Added.
+
2008-01-28 Oliver Hunt <oliver@apple.com>
RS=Mark.
--- /dev/null
+<html>
+<head>
+</head>
+<body>
+ <div id="target" style="height: 90px;">
+ <div style="height: 100px; width: 100px; background: red;">
+ <div style="float: left; height: 100px; width: 100px; background-color: green;"></div>
+ </div>
+ </div>
+ <script>
+ function test()
+ {
+ document.getElementById("target").style.height = "110px";
+ }
+
+ document.body.offsetTop;
+ test();
+ </script>
+</body>
+</html>
--- /dev/null
+18f1f64eab31dfb69467a497de9442d7
\ No newline at end of file
--- /dev/null
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 784x110
+ RenderBlock {DIV} at (0,0) size 100x100 [bgcolor=#FF0000]
+ RenderBlock (floating) {DIV} at (0,0) size 100x100 [bgcolor=#008000]
+2008-01-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Darin Adler.
+
+ - fix http://bugs.webkit.org/show_bug.cgi?id=16774
+ REGRESSION (r27464-r27504) javascript popup menu does not display 'close' button
+
+ Test: fast/dynamic/float-no-longer-overhanging.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::addOverhangingFloats): If a child's float turns
+ out not to be overhanging at this time, ensure that the child paints it.
+
2008-01-28 Oliver Hunt <oliver@apple.com>
More wx fixes
}
m_floatingObjects->append(floatingObj);
}
- }
+ } else
+ r->noPaint = false;
+
if (!r->noPaint && !r->node->hasLayer()) {
IntRect floatOverflowRect = r->node->overflowRect(false);
floatOverflowRect.move(r->left + r->node->marginLeft(), r->startY + r->node->marginTop());