[Replaceable] attributes must be readonly

https://bugs.webkit.org/show_bug.cgi?id=115692

Reviewed by Kentaro Hara.

Merge https://chromium.googlesource.com/chromium/blink/+/ac61fbfe875d3c3c37d529683139ceb0ad4330bb.

Web IDL specification says [Replaceable] attributes are readonly:
http://www.w3.org/TR/2012/CR-WebIDL-20120419/#Replaceable

Update the two instances of [Replaceable] in WebCore that didn't have readonly modifier to match
the specifcation and the rest of WebCore. There should be no behavioral changes as the code generator
already assumed [Replaceable] attributes are readonly.

* html/HTMLDocument.idl:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 115695daa9b6fa5850902b38192e8552634ba1ea..bc23c919bfda48ca9355fffd0e3370a4262c5fbb 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,22 @@
+2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
+
+        [Replaceable] attributes must be readonly
+        https://bugs.webkit.org/show_bug.cgi?id=115692
+
+        Reviewed by Kentaro Hara.
+
+        Merge https://chromium.googlesource.com/chromium/blink/+/ac61fbfe875d3c3c37d529683139ceb0ad4330bb.
+
+        Web IDL specification says [Replaceable] attributes are readonly:
+        http://www.w3.org/TR/2012/CR-WebIDL-20120419/#Replaceable
+
+        Update the two instances of [Replaceable] in WebCore that didn't have readonly modifier to match
+        the specifcation and the rest of WebCore. There should be no behavioral changes as the code generator
+        already assumed [Replaceable] attributes are readonly.
+
+        * html/HTMLDocument.idl:
+        * page/DOMWindow.idl:
+
 2013-05-06  Darin Adler  <darin@apple.com>
 
         Use OwnPtr instead of deleteAllValues in DocumentMarkerController

diff --git a/Source/WebCore/html/HTMLDocument.idl b/Source/WebCore/html/HTMLDocument.idl
index fa583fdb841f9ac458e5dafd3c7471fa4ad52d98..a09f0060d0d78afb3f73396bc5c9de53e22bb1f0 100644 (file)
--- a/Source/WebCore/html/HTMLDocument.idl
+++ b/Source/WebCore/html/HTMLDocument.idl
@@ -34,7 +34,7 @@
 
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
     // FIXME: This should eventually be available (if they are wanted) for all languages.
-    [Custom, Replaceable, Deletable] attribute HTMLAllCollection all;
+    [Custom, Replaceable, Deletable] readonly attribute HTMLAllCollection all;
 #endif
 
     void clear();

diff --git a/Source/WebCore/page/DOMWindow.idl b/Source/WebCore/page/DOMWindow.idl
index b7e5e69425141d5beacdc918aac83dfa54195c6c..7ac729d926784d6a65ff4b303565419f4e7a4377 100644 (file)
--- a/Source/WebCore/page/DOMWindow.idl
+++ b/Source/WebCore/page/DOMWindow.idl
@@ -210,7 +210,7 @@
     DOMString btoa([TreatNullAs=NullString,Default=Undefined] optional DOMString string)
         raises(DOMException);
 
-    attribute [Replaceable,Conditional=CSS3_CONDITIONAL_RULES] DOMWindowCSS CSS;
+    readonly attribute [Replaceable,Conditional=CSS3_CONDITIONAL_RULES] DOMWindowCSS CSS;
 
     // Events
     attribute EventListener onabort;