Add some missing virtual keywords on derived-class destructors
authoraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 May 2011 20:55:44 +0000 (20:55 +0000)
committeraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 May 2011 20:55:44 +0000 (20:55 +0000)
Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
just matches our style of explicitly marking overrides "virtual".

* WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and
WebInspectorFrontendClient destructors explicitly virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/win/ChangeLog
Source/WebKit/win/WebCoreSupport/WebInspectorClient.h

index 9d0f75c6337aabc6144400a9fc2f7944d5604fd7..4694dda2a28a2ecb1b472b955efd6bc3399a407b 100644 (file)
@@ -1,3 +1,13 @@
+2011-05-03  Adam Roben  <aroben@apple.com>
+
+        Add some missing virtual keywords on derived-class destructors
+
+        Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
+        just matches our style of explicitly marking overrides "virtual".
+
+        * WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and
+        WebInspectorFrontendClient destructors explicitly virtual.
+
 2011-05-03  Adam Roben  <aroben@apple.com>
 
         Fix most strict PassOwnPtr violations on Windows
 2011-05-03  Adam Roben  <aroben@apple.com>
 
         Fix most strict PassOwnPtr violations on Windows
index 3633d7f36effce1322fa9c5259ce550ae5abcfbd..7220a47bc83bc0376b57268f7259c243156486d5 100644 (file)
@@ -79,7 +79,7 @@ public:
     void loadSessionSetting(const WTF::String& key, WTF::String* value);
 
 private:
     void loadSessionSetting(const WTF::String& key, WTF::String* value);
 
 private:
-    ~WebInspectorClient();
+    virtual ~WebInspectorClient();
     WTF::PassOwnPtr<WebCore::InspectorFrontendClientLocal::Settings> createFrontendSettings();
 
     WebView* m_inspectedWebView;
     WTF::PassOwnPtr<WebCore::InspectorFrontendClientLocal::Settings> createFrontendSettings();
 
     WebView* m_inspectedWebView;
@@ -95,7 +95,7 @@ private:
 class WebInspectorFrontendClient : public WebCore::InspectorFrontendClientLocal, WebCore::WindowMessageListener {
 public:
     WebInspectorFrontendClient(WebView* inspectedWebView, HWND inspectedWebViewHwnd, HWND frontendHwnd, const COMPtr<WebView>& frotnendWebView, HWND frontendWebViewHwnd, WebInspectorClient*, WTF::PassOwnPtr<Settings>);
 class WebInspectorFrontendClient : public WebCore::InspectorFrontendClientLocal, WebCore::WindowMessageListener {
 public:
     WebInspectorFrontendClient(WebView* inspectedWebView, HWND inspectedWebViewHwnd, HWND frontendHwnd, const COMPtr<WebView>& frotnendWebView, HWND frontendWebViewHwnd, WebInspectorClient*, WTF::PassOwnPtr<Settings>);
-    ~WebInspectorFrontendClient();
+    virtual ~WebInspectorFrontendClient();
 
     virtual void frontendLoaded();
     
 
     virtual void frontendLoaded();