Web Inspector: Regression: Showing of color swatches no longer works in Details Sidebar
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Apr 2015 01:02:14 +0000 (01:02 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Apr 2015 01:02:14 +0000 (01:02 +0000)
https://bugs.webkit.org/show_bug.cgi?id=143539

Patch by Tobias Reiss <tobi+webkit@basecode.de> on 2015-04-08
Reviewed by Timothy Hatcher.

Fix a regression where due to an ESLint error the whole line instead of just
the variable declaration was removed.

* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js

index f1ac56dfb9d1b126d1879362d976d89b9632e6d8..9418f869586bbc037840077620dee65ab96fb790 100644 (file)
@@ -1,3 +1,17 @@
+2015-04-08  Tobias Reiss  <tobi+webkit@basecode.de>
+
+        Web Inspector: Regression: Showing of color swatches no longer works in Details Sidebar
+        https://bugs.webkit.org/show_bug.cgi?id=143539
+
+        Reviewed by Timothy Hatcher.
+
+        Fix a regression where due to an ESLint error the whole line instead of just
+        the variable declaration was removed.
+
+        * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+        (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches.update):
+        (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
+
 2015-04-07  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: ES6: Show Symbol properties on Objects
index 93dbe9d3eb7c33a843a42fe41784df8f3fe5fff1..703c95bc059cc2721a3b55b3084cd8c4fa068251 100644 (file)
@@ -393,6 +393,7 @@ WebInspector.CSSStyleDeclarationTextEditor = class CSSStyleDeclarationTextEditor
                 swatchElement.appendChild(swatchInnerElement);
 
                 var codeMirrorTextMarker = marker.codeMirrorTextMarker;
+                this._codeMirror.setUniqueBookmark(codeMirrorTextMarker.find().from, swatchElement);
 
                 swatchInnerElement.__colorTextMarker = codeMirrorTextMarker;
                 swatchInnerElement.__color = color;