2011-02-23 Ojan Vafai <ojan@chromium.org>

        Reviewed by Tony Chang.

        autocomplete=off prevents refilling form fields on back/forward navigation
        https://bugs.webkit.org/show_bug.cgi?id=47463

        I haven't actually run this patch due to the difficulty of getting
        a bugzilla instance running. It's simple enough code that I'm not too worried
        about it.

        * committers-autocomplete.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index f285d7b3f94931b45ef94f8894439021f427ff08..3e526ac0a662622a07f2238ea5665fe39142c6ac 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,16 @@
+2011-02-23  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        autocomplete=off prevents refilling form fields on back/forward navigation
+        https://bugs.webkit.org/show_bug.cgi?id=47463
+
+        I haven't actually run this patch due to the difficulty of getting
+        a bugzilla instance running. It's simple enough code that I'm not too worried
+        about it.
+
+        * committers-autocomplete.js:
+
 2011-02-21  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/Websites/bugs.webkit.org/committers-autocomplete.js b/Websites/bugs.webkit.org/committers-autocomplete.js
index ea947a412a26ac84cecbf2755978747083bc2d2e..8d071aab666c2d57852b1f2a164f4bac79897013 100644 (file)
--- a/Websites/bugs.webkit.org/committers-autocomplete.js
+++ b/Websites/bugs.webkit.org/committers-autocomplete.js
@@ -371,6 +371,7 @@ WebKitCommitters = (function() {
 
         if (!getMenu()) {
             createMenu(m_focusedInput.name);
+            // Turn off autocomplete to avoid showing the browser's dropdown menu.
             m_focusedInput.setAttribute('autocomplete', 'off');
             m_focusedInput.addEventListener('keyup', handleKeyUp, false);
             m_focusedInput.addEventListener('keydown', handleKeyDown, false);
@@ -379,6 +380,10 @@ WebKitCommitters = (function() {
                 m_prefix = null;
                 m_selectedIndex = 0;
             }, false);
+            // Turn on autocomplete on submit to avoid breaking autofill on back/forward navigation.
+            m_focusedInput.form.addEventListener("submit", function() {
+                m_focusedInput.setAttribute("autocomplete", "on");
+            }, false);
         }
         
         updateMenu();