Reviewed by Darin.
authoralice.liu@apple.com <alice.liu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Jan 2008 21:21:48 +0000 (21:21 +0000)
committeralice.liu@apple.com <alice.liu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Jan 2008 21:21:48 +0000 (21:21 +0000)
        This fixes pageup/down in iframes.  test for this is fast/frames/iframe-scroll-page-up-down.html

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView doCommandBySelector:]):
        Have the editor handle all the commands it supports instead of just text commands.
        If not handled by the editor, the webview will handle the command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/mac/ChangeLog
WebKit/mac/WebView/WebHTMLView.mm

index c5536618885438718361f0b4d755b59c5f9bbe51..c755d843ea371ac63056b482521502b19e20d235 100644 (file)
@@ -1,3 +1,14 @@
+2008-01-03  Alice Liu  <alice.liu@apple.com>
+
+        Reviewed by Darin.
+
+        This fixes pageup/down in iframes.  test for this is fast/frames/iframe-scroll-page-up-down.html
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView doCommandBySelector:]):
+        Have the editor handle all the commands it supports instead of just text commands.
+        If not handled by the editor, the webview will handle the command. 
+
 2008-01-02  Kevin Decker  <kdecker@apple.com>
 
         Reviewed by Darin.
index e244a27ecd73c962d00273a1c412eabba64aacd7..7b9c23aa30efab6ebd604bcf43b52a504f6fd8dd 100644 (file)
@@ -5062,7 +5062,7 @@ static void extractUnderlines(NSAttributedString *string, Vector<CompositionUnde
         Frame* coreFrame = core([self _frame]);
         if (![[webView _editingDelegateForwarder] webView:webView doCommandBySelector:selector] && coreFrame) {
             Editor::Command command = [self coreCommandBySelector:selector];
-            if (command.isTextInsertion())
+            if (command.isSupported())
                 eventWasHandled = command.execute(event);
             else {
                 _private->selectorForDoCommandBySelector = selector;