+2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
+
+ Unreviewed build fix after r174555.
+
+ * public/include/manifest.php:
+ (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
+ * tests/admin-regenerate-manifest.js: Fixed the test case.
+
2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
New perf dashboard UI tries to fetch commits all the time
$repositories_table = $this->db->fetch_table('repositories');
$repositories_with_commit = $this->db->query_and_fetch_all(
- 'SELECT DISTINCT(commit_repository) FROM commits WHERE commit_reported IS TRUE') or array();
+ 'SELECT DISTINCT(commit_repository) FROM commits WHERE commit_reported IS TRUE');
+ if (!$repositories_with_commit)
+ $repositories_with_commit = array();
+
foreach ($repositories_with_commit as &$row)
$row = $row['commit_repository'];
assert.equal(response.statusCode, 200);
var manifest = JSON.parse(response.responseText);
assert.deepEqual(manifest['repositories'], {
- 'WebKit': { url: 'trac.webkit.org', blameUrl: null },
- 'Chromium': { url: null, blameUrl: 'SomeBlameURL' }
+ 'WebKit': { url: 'trac.webkit.org', blameUrl: null, hasReportedCommits: false },
+ 'Chromium': { url: null, blameUrl: 'SomeBlameURL', hasReportedCommits: false }
});
assert.deepEqual(manifest['bugTrackers']['Bugzilla'], { newBugUrl: null, repositories: ['WebKit'] });
assert.deepEqual(manifest['bugTrackers']['Issue Tracker'], { newBugUrl: null, repositories: ['WebKit', 'Chromium'] });