Slight logic reordering in JSImmediate::from(double)

Reviewed by Geoff.

This gives a 0.1% improvement in SunSpider.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index 4b52650c64e24c4aa6a9f7bf8bdc99430c4215de..94a13e9d848d0c2aad145a9a13c71adfa78df608 100644 (file)
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,14 @@
+2007-12-20  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Geoff.
+
+        Slight logic reordering in JSImmediate::from(double)
+
+        This gives a 0.1% improvement in SunSpider.
+
+        * kjs/JSImmediate.h:
+        (KJS::JSImmediate::from):
+

 2007-12-20  Eric Seidel  <eric@webkit.org>
 
         Reviewed by Geoff, then re-rubber-stamped by Geoff after final search/replace and testing.
 2007-12-20  Eric Seidel  <eric@webkit.org>
 
         Reviewed by Geoff, then re-rubber-stamped by Geoff after final search/replace and testing.

diff --git a/JavaScriptCore/kjs/JSImmediate.h b/JavaScriptCore/kjs/JSImmediate.h
index 049b4c71704c00fcc7036c390f4d43d8d6228359..bc0cb161e8c08dea477a1d47cf0ac13b5aab13fb 100644 (file)
--- a/JavaScriptCore/kjs/JSImmediate.h
+++ b/JavaScriptCore/kjs/JSImmediate.h
@@ -234,7 +234,7 @@ ALWAYS_INLINE JSValue* JSImmediate::from(double d)
         return 0;
 
     // Check for data loss from conversion to int.
         return 0;
 
     // Check for data loss from conversion to int.

-    if ((intVal != d) || (signbit(d) && !intVal))
+    if ((intVal != d) || (!intVal && signbit(d)))

         return 0;
 
     return tag(intVal << 2, NumberType);
         return 0;
 
     return tag(intVal << 2, NumberType);