2011-04-12 Kent Tamura <tkent@chromium.org>
authortkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Apr 2011 05:47:47 +0000 (05:47 +0000)
committertkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Apr 2011 05:47:47 +0000 (05:47 +0000)
        Reviewed by Dimitri Glazkov.

        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
        https://bugs.webkit.org/show_bug.cgi?id=57426

        * platform/chromium/test_expectations.txt:
          Remove validation-message-appearance.html because it becomes non-flaky
          by the DRT change.
2011-04-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
        https://bugs.webkit.org/show_bug.cgi?id=57426

        * public/WebSettings.h: Declare new function.
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setValidationMessageTimerMagnification):
         Passing the specified value to WebCore::Settings.
        * src/WebSettingsImpl.h: Declare new function.
2011-04-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
        https://bugs.webkit.org/show_bug.cgi?id=57426

        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::applyTo): Disable the validation message timer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/chromium/test_expectations.txt
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/public/WebSettings.h
Source/WebKit/chromium/src/WebSettingsImpl.cpp
Source/WebKit/chromium/src/WebSettingsImpl.h
Tools/ChangeLog
Tools/DumpRenderTree/chromium/WebPreferences.cpp

index 253eb9628df538249137f758add0d1dfc8380f91..d5c580f3aa63f6fdf4a0c9742cf236d27167c225 100644 (file)
@@ -1,3 +1,14 @@
+2011-04-12  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
+        https://bugs.webkit.org/show_bug.cgi?id=57426
+
+        * platform/chromium/test_expectations.txt:
+          Remove validation-message-appearance.html because it becomes non-flaky
+          by the DRT change.
+
 2011-04-12  Sergey Glazunov  <serg.glazunov@gmail.com>
 
         Reviewed by Dimitri Glazkov.
index 59f6b0667477f9a693bc5ba4e3a25afe2ad29c2e..b6ecacae25d653fecd0bfcec134a94b5597ee1ae 100644 (file)
@@ -785,9 +785,6 @@ BUGCR20226 : fast/forms/datalist.html = TEXT
 BUGCR20226 : fast/forms/input-list.html = FAIL
 BUGCR20226 : fast/forms/input-selectedoption.html = FAIL
 
-// Needs to call Settings::setValidationMessageTimerMagnification(-1).
-BUGWK57290 : fast/forms/validation-message-appearance.html = PASS FAIL
-
 // Timing out.
 BUGCR78376 SKIP : http/tests/media/video-play-stall-seek.html = TIMEOUT
 
index 17d350eb46d4083282296cb6a2967a84be95f82a..0ca9d6678226751a12414e780e5745a50740f9ab 100644 (file)
@@ -1,3 +1,16 @@
+2011-04-12  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
+        https://bugs.webkit.org/show_bug.cgi?id=57426
+
+        * public/WebSettings.h: Declare new function.
+        * src/WebSettingsImpl.cpp:
+        (WebKit::WebSettingsImpl::setValidationMessageTimerMagnification):
+         Passing the specified value to WebCore::Settings.
+        * src/WebSettingsImpl.h: Declare new function.
+
 2011-04-12  Antoine Labour  <piman@chromium.org>
 
         Reviewed by Kenneth Russell.
index 56032c1532aa21aeaa777d94c64efb01193cff17..ed4e6efa3eae8cbeaf9670136c2e63abdc5d758c 100644 (file)
@@ -116,6 +116,7 @@ public:
     virtual void setAsynchronousSpellCheckingEnabled(bool) = 0;
     virtual void setCaretBrowsingEnabled(bool) = 0;
     virtual void setInteractiveFormValidationEnabled(bool) = 0;
+    virtual void setValidationMessageTimerMagnification(int) = 0;
     virtual void setMinimumTimerInterval(double) = 0;
     virtual void setFullScreenEnabled(bool) = 0;
 
index 73cc7c54fb11dcb03811adde363afb7e81efbd4d..c5b60ccf57030c560fccabd5ca39c47d4ce51b1f 100644 (file)
@@ -378,6 +378,11 @@ void WebSettingsImpl::setInteractiveFormValidationEnabled(bool enabled)
     m_settings->setInteractiveFormValidationEnabled(enabled);
 }
 
+void WebSettingsImpl::setValidationMessageTimerMagnification(int newValue)
+{
+    m_settings->setValidationMessageTimerMagnification(newValue);
+}
+
 void WebSettingsImpl::setMinimumTimerInterval(double interval)
 {
     m_settings->setMinDOMTimerInterval(interval);
index 798a78fc04ffab83f8da5d7803c3633f4656fff0..57aa804eeff3b51a8bdaa61b6f4355e32962bec0 100644 (file)
@@ -109,6 +109,7 @@ public:
     virtual void setAsynchronousSpellCheckingEnabled(bool);
     virtual void setCaretBrowsingEnabled(bool);
     virtual void setInteractiveFormValidationEnabled(bool);
+    virtual void setValidationMessageTimerMagnification(int);
     virtual void setMinimumTimerInterval(double);
     virtual void setFullScreenEnabled(bool);
 
index a8c2ef57b62bc1b29aa42ffb3af80744ff90bd84..a81af3b974e976c11ce90262568fd7b52a123018 100644 (file)
@@ -1,3 +1,13 @@
+2011-04-12  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
+        https://bugs.webkit.org/show_bug.cgi?id=57426
+
+        * DumpRenderTree/chromium/WebPreferences.cpp:
+        (WebPreferences::applyTo): Disable the validation message timer.
+
 2011-04-12  James Kozianski  <koz@chromium.org>
 
         Unreviewed.
index 5783bdcb5c7f70511d84e7f92b5698d6e61fdc68..c609397a4ba15cb02c3169750619ba9f5a707891 100644 (file)
@@ -165,8 +165,8 @@ void WebPreferences::applyTo(WebView* webView)
     settings->setUsesEncodingDetector(false);
     settings->setImagesEnabled(true);
     settings->setInteractiveFormValidationEnabled(true);
-
     // Enable fullscreen so the fullscreen layout tests can run.
     settings->setFullScreenEnabled(true);
+    settings->setValidationMessageTimerMagnification(-1);
 }