[iOS] Don't turn fields yellow after filling credentials
authorcpugh@apple.com <cpugh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Oct 2017 23:38:26 +0000 (23:38 +0000)
committercpugh@apple.com <cpugh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Oct 2017 23:38:26 +0000 (23:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=178411

Reviewed by Wenson Hsieh.

* editing/ios/AutofillElements.cpp:
(WebCore::AutofillElements::autofill): We don't want to turn fields yellow when filling the user name
and password. Remove the code that was causing that to happen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/editing/ios/AutofillElements.cpp

index d7e46e6d433b72771593364ea13671d0a18ef86d..74d1d12a926bb2f4d30a6c65f2ece64b05cb2352 100644 (file)
@@ -1,3 +1,14 @@
+2017-10-17  Chelsea Pugh  <cpugh@apple.com>
+
+        [iOS] Don't turn fields yellow after filling credentials
+        https://bugs.webkit.org/show_bug.cgi?id=178411
+
+        Reviewed by Wenson Hsieh.
+
+        * editing/ios/AutofillElements.cpp:
+        (WebCore::AutofillElements::autofill): We don't want to turn fields yellow when filling the user name
+        and password. Remove the code that was causing that to happen.
+
 2017-10-16  Andy Estes  <aestes@apple.com>
 
         [Apple Pay] Add subLocality and subAdministrativeArea to ApplePayPaymentContact and ApplePayError
index 9ba8a44c596d8562f49c54e8a334868cea073451..75b1a04d47211c5ba229b2923ca5c85cb2cbbd1f 100644 (file)
@@ -119,14 +119,10 @@ std::optional<AutofillElements> AutofillElements::computeAutofillElements(Ref<HT
 
 void AutofillElements::autofill(String username, String password)
 {
-    if (m_username) {
+    if (m_username)
         m_username->setValueForUser(username);
-        m_username->setAutoFilled();
-    }
-    if (m_password) {
+    if (m_password)
         m_password->setValueForUser(password);
-        m_password->setAutoFilled();
-    }
 }
 
 } // namespace WebCore