fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 29 Jul 2014 22:41:19 +0000 (22:41 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 29 Jul 2014 22:41:19 +0000 (22:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=135398

Reviewed by Zalan Bujtas.

Tools:
* WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
"hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.

* DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
sure why.

LayoutTests:
* platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was
the actual reason for it to appear failing?

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@171772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac-wk2/TestExpectations
Tools/ChangeLog
Tools/DumpRenderTree/mac/DumpRenderTree.mm
Tools/WebKitTestRunner/TestController.cpp

index 34daeedebfdb3ab2b6057a65d14b559fab64759b..9eb86f8e5cce41439c3bfa5c75522444129af365 100644 (file)
@@ -1,3 +1,13 @@
+2014-07-29  Alexey Proskuryakov  <ap@apple.com>
+
+        fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
+        https://bugs.webkit.org/show_bug.cgi?id=135398
+
+        Reviewed by Zalan Bujtas.
+
+        * platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was
+        the actual reason for it to appear failing?
+
 2014-07-29  Mihnea Ovidenie  <mihnea@adobe.com>
 
         [CSSRegions] Assertion failure hit testing a region-based multicolumn in a region
index 90b7652201f2b6725a8dd2691db7a0860794e8d7..8e1e9b04294ba0fd2e41adcdb4aae9a052c21f46 100644 (file)
@@ -297,7 +297,6 @@ webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-simple-container-la
 webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-transform-with-render-layer-on-fractional-pixel-value.html [ ImageOnlyFailure ]
 webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-nested-compositing-layers-with-subpixel-accumulation.html [ ImageOnlyFailure ]
 webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-box-positioned-off-by-one-when-non-compositing-transform-is-present.html [ ImageOnlyFailure ]
-webkit.org/b/130175 [ MountainLion ] fast/borders/border-radius-on-subpixel-position-non-hidpi.html [ Pass ImageOnlyFailure ]
 
 # Only failing on WK1
 webkit.org/b/104104 fast/overflow/scrollbar-click-retains-focus.html [ Pass ]
index a041ce16b3cbbe6a50e38ffb645e67a658404aea..a0a7eaff99379f6d7047143f92ec73242a6ddbe6 100644 (file)
@@ -1,3 +1,17 @@
+2014-07-29  Alexey Proskuryakov  <ap@apple.com>
+
+        fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
+        https://bugs.webkit.org/show_bug.cgi?id=135398
+
+        Reviewed by Zalan Bujtas.
+
+        * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
+        "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
+        For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
+        sure why.
+
 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
 
         PPT: run-webkit-tests doesn't upload crash logs to bots
index 574d25430bbe122ef6822bd1c096934084c4a294..8e8a6c61dd95d63158536b2ff61f3cd9ca94fb7c 100644 (file)
@@ -1467,7 +1467,7 @@ static void changeWindowScaleIfNeeded(const char* testPathOrUR)
 {
     bool hasHighDPIWindow = [[[mainFrame webView] window] backingScaleFactor] != 1;
     WTF::String localPathOrUrl = String(testPathOrUR);
-    bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("hidpi-") != notFound;
+    bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("/hidpi-") != notFound;
     if (hasHighDPIWindow == needsHighDPIWindow)
         return;
 
index 5a3151d39149530888e08a5c4bcfa4506e353c4e..b70736df39469c0714894248d684d755021f69fc 100644 (file)
@@ -680,7 +680,7 @@ void TestController::updateWebViewSizeForTest(const TestInvocation& test)
 void TestController::updateWindowScaleForTest(const TestInvocation& test)
 {
     WTF::String localPathOrUrl = String(test.pathOrURL());
-    bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("hidpi-") != notFound;
+    bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("/hidpi-") != notFound;
     mainWebView()->changeWindowScaleIfNeeded(needsHighDPIWindow ? 2 : 1);
 }