Web Inspector: in some cases Popover code is failing to calculate popover box position.
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Aug 2011 12:32:46 +0000 (12:32 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Aug 2011 12:32:46 +0000 (12:32 +0000)
https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._positionElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/Popover.js

index fa772e9eddf35cde0932722020b73054da2bc02f..31fe3e9bd154424df259a7fb0812af2d111d7d81 100644 (file)
@@ -1,3 +1,13 @@
+2011-08-26  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: in some cases Popover code is failing to calculate popover box position.
+        https://bugs.webkit.org/show_bug.cgi?id=67029
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/Popover.js:
+        (WebInspector.Popover.prototype._positionElement):
+
 2011-08-26  Nikolas Zimmermann  <nzimmermann@rim.com>
 
         [Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
index 551d8c8d1aad892ac671e7d02204b8dfeb98a415..5d65612f7f1edc83949e93fce2dd52cc0a84d033 100644 (file)
@@ -113,7 +113,7 @@ WebInspector.Popover.prototype = {
         var anchorBox = anchorElement.offsetRelativeToWindow(window);
         anchorBox.width = anchorElement.offsetWidth;
         anchorBox.height = anchorElement.offsetHeight;
-        while (anchorElement !== anchorElement.ownerDocument.body) {
+        while (anchorElement && anchorElement !== anchorElement.ownerDocument.body) {
             if (anchorElement.scrollLeft)
                 anchorBox.x -= anchorElement.scrollLeft;
             if (anchorElement.scrollTop)