https://bugs.webkit.org/show_bug.cgi?id=98527
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-11
Reviewed by Kenneth Rohde Christiansen.
Tools:
Added decidePolicyForResponse callback for WTR PagePolicyClient.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::decidePolicyForResponse):
(WTR):
* WebKitTestRunner/TestController.h:
(TestController):
LayoutTests:
Rebased http/tests/loading/text-content-type-with-binary-extension.html for WK2 EFL, as dumping order is affected.
Other WK2 ports will have to do the same.
* platform/efl-wk2/http/tests/loading/text-content-type-with-binary-extension-expected.txt: Added.
* platform/gtk-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2012-10-11 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
+
+ REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
+ https://bugs.webkit.org/show_bug.cgi?id=98527
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Rebased http/tests/loading/text-content-type-with-binary-extension.html for WK2 EFL, as dumping order is affected.
+ Other WK2 ports will have to do the same.
+
+ * platform/efl-wk2/http/tests/loading/text-content-type-with-binary-extension-expected.txt: Added.
+ * platform/gtk-wk2/TestExpectations:
+ * platform/mac-wk2/TestExpectations:
+ * platform/qt-5.0-wk2/TestExpectations:
+
2012-10-11 Zan Dobersek <zandobersek@gmail.com>
Unreviewed GTK gardening.
--- /dev/null
+main frame - didStartProvisionalLoadForFrame
+main frame - didCommitLoadForFrame
+frame "iframe" - didStartProvisionalLoadForFrame
+frame "iframe" - didFailProvisionalLoadWithError
+main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+Test for https://bugs.webkit.org/show_bug.cgi?id=17360 REGRESSION: mp4 file downloaded from server is downloaded as html.
+
+Binary data not loaded as text. Maybe PASS.
+
+
Bug(GTK) svg/dom/viewspec-parser-4.html [ Pass ]
Bug(GTK) svg/dom/viewspec-parser-5.html [ Pass ]
+# Will need rebaselining after bug 98527 fixed
+webkit.org/b/98527 http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
+
#////////////////////////////////////////////////////////////////////////////////////////
# End of Tests working in WK2 and failing in WK1
#////////////////////////////////////////////////////////////////////////////////////////
webkit.org/b/96832 fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html [ Failure ]
webkit.org/b/96832 fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html [ Failure ]
-# http/tests/loading/text-content-type-with-binary-extension.html fails on Mac WK2 bots
-# https://bugs.webkit.org/show_bug.cgi?id=98527
+# Will need rebaselining after bug 98527 fixed
webkit.org/b/98527 http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
# Causes next test to crash
webkit.org/b/98897 fast/repaint/overflow-flipped-writing-mode-block-in-regions.html [ ImageOnlyFailure ]
webkit.org/b/98897 fast/repaint/textarea-set-disabled.html [ ImageOnlyFailure ]
-# [Qt][WK2] REGRESSION(r130967): It made http/tests/loading/text-content-type-with-binary-extension.html fail
-webkit.org/b/98994 http/tests/loading/text-content-type-with-binary-extension.html
+# Will need rebaselining after bug 98527 fixed
+webkit.org/b/98994 http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
# [Qt] some tests fail after unskipped in r131044
# https://bugs.webkit.org/show_bug.cgi?id=99034
+2012-10-11 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
+
+ REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
+ https://bugs.webkit.org/show_bug.cgi?id=98527
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Added decidePolicyForResponse callback for WTR PagePolicyClient.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::initialize):
+ (WTR::TestController::decidePolicyForResponse):
+ (WTR):
+ * WebKitTestRunner/TestController.h:
+ (TestController):
+
2012-10-11 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
[Qt] Make sure that -Wno-c++0x-compat is set even with production_build
this,
decidePolicyForNavigationAction,
0, // decidePolicyForNewWindowAction
- 0, // decidePolicyForResponse
+ decidePolicyForResponse,
0, // unableToImplementPolicy
};
WKPageSetPagePolicyClient(m_mainWebView->page(), &pagePolicyClient);
WKFramePolicyListenerUse(listener);
}
+void TestController::decidePolicyForResponse(WKPageRef, WKFrameRef, WKURLResponseRef, WKURLRequestRef, WKFramePolicyListenerRef listener, WKTypeRef, const void* clientInfo)
+{
+ static_cast<TestController*>(const_cast<void*>(clientInfo))->decidePolicyForResponse(listener);
+}
+
+void TestController::decidePolicyForResponse(WKFramePolicyListenerRef listener)
+{
+ // Response was already checked by WKBundlePagePolicyClient, so if we are here we're supposed to ignore.
+ WKFramePolicyListenerIgnore(listener);
+}
+
} // namespace WTR
static void decidePolicyForNavigationAction(WKPageRef, WKFrameRef, WKFrameNavigationType, WKEventModifiers, WKEventMouseButton, WKURLRequestRef, WKFramePolicyListenerRef, WKTypeRef, const void*);
void decidePolicyForNavigationAction(WKFramePolicyListenerRef);
+ static void decidePolicyForResponse(WKPageRef, WKFrameRef, WKURLResponseRef, WKURLRequestRef, WKFramePolicyListenerRef, WKTypeRef, const void*);
+ void decidePolicyForResponse(WKFramePolicyListenerRef);
+
static WKPageRef createOtherPage(WKPageRef oldPage, WKURLRequestRef, WKDictionaryRef, WKEventModifiers, WKEventMouseButton, const void*);
static void runModal(WKPageRef, const void* clientInfo);