Reviewed by Oliver Hunt.
authormitz <mitz@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 2 Nov 2007 06:27:29 +0000 (06:27 +0000)
committermitz <mitz@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 2 Nov 2007 06:27:29 +0000 (06:27 +0000)
        - fix an assertion failure when Command-Tabbing out of Safari

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to
        webCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/WebView/WebHTMLView.mm

index c9984816d19569d69c9bb819e150d6050f64a702..7213adcdcfc342a914505052bbff7c3287af0dce 100644 (file)
@@ -1,3 +1,13 @@
+2007-11-01  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Oliver Hunt.
+
+        - fix an assertion failure when Command-Tabbing out of Safari
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to
+        webCore.
+
 2007-11-01  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by Oliver Hunt.
         This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition
         to the other places where it's cleared.
 
-2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
+2007-10-18  Dan Bernstein  <mitz@apple.com>
 
         Tiger build fix.
 
         * WebView/WebDataSource.mm:
         (-[WebDataSource _MIMETypeOfResponse:]):
 
-2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
+2007-10-18  Dan Bernstein  <mitz@apple.com>
 
         Reviewed by Adam Roben.
 
index 1cbd60e65d4f49ab9c6118db6a2a31e94ad1da9c..9f2f0dcae5b5b15e51ffdffdcea70f8a3ad4518d 100644 (file)
@@ -3589,7 +3589,7 @@ noPromisedData:
     RetainPtr<WebHTMLView> selfProtector = self;
     
     //Don't make an event from the function key
-    if ([event keyCode] != 63)
+    if ([event keyCode] != 0 && [event keyCode] != 63)
         core([self _frame])->eventHandler()->keyEvent(PlatformKeyboardEvent(event));
         
     [super flagsChanged:event];