Reviewed by Ken.
authordarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Feb 2005 18:23:01 +0000 (18:23 +0000)
committerdarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Feb 2005 18:23:01 +0000 (18:23 +0000)
        - fixed <rdar://problem/4006509> REGRESSION (171-172): Setting CSS -khtml-user-modify property triggers crash

        * khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
        Removed the code that changes the style of the element. This was never needed, and caused the
        style to be modified while we were iterating it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/css/cssstyleselector.cpp

index f4f46ed175c175bd7a916fd08744e03305f32004..2572567ab6cdfbcc8875640a5863e54550ac1db6 100644 (file)
@@ -1,3 +1,13 @@
+2005-02-23  Darin Adler  <darin@apple.com>
+
+        Reviewed by Ken.
+
+        - fixed <rdar://problem/4006509> REGRESSION (171-172): Setting CSS -khtml-user-modify property triggers crash
+
+        * khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
+        Removed the code that changes the style of the element. This was never needed, and caused the
+        style to be modified while we were iterating it.
+
 2005-02-23  Ken Kocienda  <kocienda@apple.com>
 
         Reviewed by John
index 77e9707c73a06bfe8caeb16bae8c161130225f5a..2340b7f2b0ddbb5a3ff1cee1d7dca70c40c70c39 100644 (file)
@@ -3695,17 +3695,6 @@ void CSSStyleSelector::applyProperty( int id, DOM::CSSValueImpl *value )
             return;
         EUserModify userModify = EUserModify(primitiveValue->getIdent() - CSS_VAL_READ_ONLY);
         style->setUserModify(userModify);
-        KHTMLPart *part = element->getDocument()->part();
-        if (part) {
-            switch (userModify) {
-                case READ_ONLY:
-                    part->removeEditingStyleFromElement(element);
-                    break;
-                case READ_WRITE:
-                    part->applyEditingStyleToElement(element);
-                    break;
-            }
-        }
         break;
     }
     case CSS_PROP__KHTML_USER_SELECT: {