Web Inspector: Fix ESLint no-extra-semi
authorjonowells@apple.com <jonowells@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Sep 2014 17:31:18 +0000 (17:31 +0000)
committerjonowells@apple.com <jonowells@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Sep 2014 17:31:18 +0000 (17:31 +0000)
https://bugs.webkit.org/show_bug.cgi?id=136666

Reviewed by Andy Estes.

Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
semicolons as identified by ESLint.

* .eslintrc:
* Tools/PrettyPrinting/Formatter.js:
(Formatter):
* UserInterface/Controllers/Formatter.js:
(Formatter):
* UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize):
* UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
* UserInterface/Views/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/.eslintrc
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/Tools/PrettyPrinting/Formatter.js
Source/WebInspectorUI/UserInterface/Controllers/Formatter.js
Source/WebInspectorUI/UserInterface/Models/Resource.js
Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js
Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js

index 0df877e8c9e4063c447c4fef7f81aaf6f2ae5b48..81b9586dd6f64f27b0ac44bc4bc092e2a6dc8876 100644 (file)
@@ -58,6 +58,7 @@
     "rules": {
         "eqeqeq": 2,
         "curly": 0,
+        "no-extra-semi": 2,
         "quotes": [2, "double"],
         "no-underscore-dangle": 0,
         "new-parens": 0,
index 285aca5f7ea7b4f3a04e24f5ac9c56a0b220cf95..188806a153bfd6d5ca79af48497395933aedfa4a 100644 (file)
@@ -1,3 +1,28 @@
+2014-09-09  Jono Wells  <jonowells@apple.com>
+
+        Web Inspector: Fix ESLint no-extra-semi
+        https://bugs.webkit.org/show_bug.cgi?id=136666
+
+        Reviewed by Andy Estes.
+
+        Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
+        semicolons as identified by ESLint.
+
+        * .eslintrc:
+        * Tools/PrettyPrinting/Formatter.js:
+        (Formatter):
+        * UserInterface/Controllers/Formatter.js:
+        (Formatter):
+        * UserInterface/Models/Resource.js:
+        (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
+        (WebInspector.Resource.prototype.getImageSize):
+        * UserInterface/Views/LayerTreeSidebarPanel.js:
+        (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
+        (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
+        * UserInterface/Views/ObjectPropertiesSection.js:
+        (WebInspector.ObjectPropertyTreeElement.prototype.callback):
+        (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
+
 2014-09-09  Jono Wells  <jonowells@apple.com>
 
         Web Inspector: Fix ESLint semi (missing semicolon)
index 524e50d5ab387e3c1a7689d1220f5f3c0c34428a..5a7f2d80a2f5541eb375f795bd0459e4ee185ce0 100644 (file)
@@ -33,7 +33,7 @@ function Formatter(codeMirror, builder)
 
     this._lastToken = null;
     this._lastContent = "";
-};
+}
 
 Formatter.prototype = {
     constructor: Formatter,
index 524e50d5ab387e3c1a7689d1220f5f3c0c34428a..5a7f2d80a2f5541eb375f795bd0459e4ee185ce0 100644 (file)
@@ -33,7 +33,7 @@ function Formatter(codeMirror, builder)
 
     this._lastToken = null;
     this._lastContent = "";
-};
+}
 
 Formatter.prototype = {
     constructor: Formatter,
index 5b210b969fb2f6c437e23da376cf9813aecd51ed..957f40069a7f8d09c42785af9f91fd54c18520a6 100644 (file)
@@ -668,7 +668,7 @@ WebInspector.Resource.prototype = {
             };
             
             callback(this._imageSize);
-        };
+        }
 
         // Create an <img> element that we'll use to load the image resource
         // so that we can query its intrinsic size.
index 3a458c9f26e2542792c62a0ccfddfcc9d0508599..5cf99698ead1bdf2ef05c71d56186a96c0eeaf03 100644 (file)
@@ -181,7 +181,7 @@ WebInspector.LayerTreeSidebarPanel.prototype = {
             var item1 = a.layer[sortColumnIdentifier] || 0;
             var item2 = b.layer[sortColumnIdentifier] || 0;
             return item1 - item2;
-        };
+        }
 
         this._dataGrid.sortNodes(comparator);
         this._updatePopoverForSelectedNode();
index a0304fc9f83e4caf0a2b67d189f9fb22cfb9ee90..350c0fa9c78c468594ac7258032c34578c5fa918 100644 (file)
@@ -335,7 +335,7 @@ WebInspector.ObjectPropertyTreeElement.prototype = {
                 // Call updateSiblings since their value might be based on the value that just changed.
                 this.updateSiblings();
             }
-        };
+        }
         this.property.parentObject.setPropertyValue(this.property.name, expression.trim(), callback.bind(this));
     }
 };