2010-10-27 Ojan Vafai <ojan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] add a master-name flag to new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=48488

        The test results server now allows adding a master name to
        the uploaded files. This lets us distinguish bots that have
        the same name, but are on different masters.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index a9aa92e4f9b7670da96c54f99ffee76003e4d5e6..1a33b99bc2c9124317347c49f27d618eefb253d2 100644 (file)
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,16 @@
+2010-10-27  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        [chromium] add a master-name flag to new-run-webkit-tests
+        https://bugs.webkit.org/show_bug.cgi?id=48488
+
+        The test results server now allows adding a master name to
+        the uploaded files. This lets us distinguish bots that have
+        the same name, but are on different masters.
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
 2010-10-28  Adam Roben  <aroben@apple.com>
 
         Don't append a newline to the test output if the frame has no document

diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index 14cf98740f10804f9c2eca85eed1ef8614063fa7..6fb6f9ae7de320ee332d06194790d46f8fba9203 100755 (executable)
--- a/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -950,7 +950,12 @@ class TestRunner:
         _log.info("Uploading JSON files for builder: %s",
                    self._options.builder_name)
 
-        attrs = [("builder", self._options.builder_name)]
+        attrs = [("builder", self._options.builder_name), ("testtype", "layout-tests")]
+        # FIXME: master_name should be required if test_results_server is set.
+        # Throw an error if master_name isn't set.
+        if self._options.master_name:
+            attrs.append(("master", self._options.master_name))
+
         json_files = ["expectations.json"]
         if self._options.upload_full_results:
             json_files.append("results.json")
@@ -1680,6 +1685,7 @@ def parse_args(args=None):
 
     # FIXME: Move these into json_results_generator.py
     results_json_options = [
+        optparse.make_option("--master-name", help="The name of the buildbot master."),
         optparse.make_option("--builder-name", default="DUMMY_BUILDER_NAME",
             help=("The name of the builder shown on the waterfall running "
                   "this script e.g. WebKit.")),