2009-06-03 Adam Langley <agl@google.com>
authoragl@chromium.org <agl@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Jun 2009 23:08:30 +0000 (23:08 +0000)
committeragl@chromium.org <agl@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Jun 2009 23:08:30 +0000 (23:08 +0000)
        Reviewed by Eric Seidel.

        Make the scrollbar thumb size twice the width for Chromium Linux. This
        matches Firefox on Linux.

        This will need layout test pixel results to be rebaselined in the
        Chromium tree.

        http://code.google.com/p/chromium/issues/detail?id=12602
        https://bugs.webkit.org/show_bug.cgi?id=26176

        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
        * platform/chromium/ScrollbarThemeChromiumLinux.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.h

index 3626997799ef8c47e83152bd0665fcbcbc9758e1..f9e03bb3d8557f5067ddefbb369a6d45b8ed385d 100644 (file)
@@ -1,3 +1,20 @@
+2009-06-03  Adam Langley  <agl@google.com>
+
+        Reviewed by Eric Seidel.
+
+        Make the scrollbar thumb size twice the width for Chromium Linux. This
+        matches Firefox on Linux.
+
+        This will need layout test pixel results to be rebaselined in the
+        Chromium tree.
+
+        http://code.google.com/p/chromium/issues/detail?id=12602
+        https://bugs.webkit.org/show_bug.cgi?id=26176
+
+        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
+        (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
+        * platform/chromium/ScrollbarThemeChromiumLinux.h:
+
 2009-06-03  Adam Langley  <agl@google.com>
 
         Reviewed by Eric Seidel.
index ba3657d533af5839e5e6f0e6ba7df07881b89bc1..6893deaf197c02a28ad5eb1dafe999565a18d9a7 100644 (file)
@@ -152,4 +152,10 @@ IntSize ScrollbarThemeChromiumLinux::buttonSize(Scrollbar* scrollbar)
     return IntSize(0, 0);
 }
 
+int ScrollbarThemeChromiumLinux::minimumThumbLength(Scrollbar* scrollbar)
+{
+    // This matches Firefox on Linux.
+    return 2 * scrollbarThickness(scrollbar->controlSize());
+}
+
 } // namespace WebCore
index 72b06b91101ef435ae69780ddb5aa8256ef5652c..4e08b07ba66084f87c76b02e90a24a66abe5b256 100644 (file)
@@ -44,6 +44,7 @@ namespace WebCore {
         virtual void paintThumb(GraphicsContext*, Scrollbar*, const IntRect&);
 
         virtual IntSize buttonSize(Scrollbar*);
+        virtual int minimumThumbLength(Scrollbar*);
     };
 } // namespace WebCore