Renaming some parameters passed to DB-related methods to better
authordumi@chromium.org <dumi@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Nov 2009 05:17:55 +0000 (05:17 +0000)
committerdumi@chromium.org <dumi@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Nov 2009 05:17:55 +0000 (05:17 +0000)
indicate their purpose.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31449

WebCore:

* platform/chromium/ChromiumBridge.h:

WebKit/chromium:

* public/WebKitClient.h:
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::databaseOpenFile):
(WebCore::ChromiumBridge::databaseDeleteFile):
(WebCore::ChromiumBridge::databaseGetFileAttributes):
(WebCore::ChromiumBridge::databaseGetFileSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/chromium/ChromiumBridge.h
WebKit/chromium/ChangeLog
WebKit/chromium/public/WebKitClient.h
WebKit/chromium/src/ChromiumBridge.cpp

index 82f2ac872fb61559720f35bf5759d6657ee79233..0d1d92b2b5c155cd99f0ddf1fdefb813b5a58ec2 100644 (file)
@@ -1,3 +1,14 @@
+2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Renaming some parameters passed to DB-related methods to better
+        indicate their purpose.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31449
+
+        * platform/chromium/ChromiumBridge.h:
+
 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
 
         Reviewed by Dan Bernstein.
index 0cee4b0cfc9c8c3e339fac5fd3be643effc6302e..3709f7c53746a2fd093706033b84ec1d25c16c72 100644 (file)
@@ -118,13 +118,13 @@ namespace WebCore {
         // HTML5 DB -----------------------------------------------------------
 #if ENABLE(DATABASE)
         // Returns a handle to the DB file and ooptionally a handle to its containing directory
-        static PlatformFileHandle databaseOpenFile(const String& fileName, int desiredFlags, PlatformFileHandle* dirHandle = 0);
+        static PlatformFileHandle databaseOpenFile(const String& vfsFleName, int desiredFlags, PlatformFileHandle* dirHandle = 0);
         // Returns a SQLite code (SQLITE_OK = 0, on success)
-        static int databaseDeleteFile(const String& fileName, bool syncDir = false);
+        static int databaseDeleteFile(const String& vfsFileName, bool syncDir = false);
         // Returns the attributes of the DB file
-        static long databaseGetFileAttributes(const String& fileName);
+        static long databaseGetFileAttributes(const String& vfsFileName);
         // Returns the size of the DB file
-        static long long databaseGetFileSize(const String& fileName);
+        static long long databaseGetFileSize(const String& vfsFileName);
 #endif
 
         // JavaScript ---------------------------------------------------------
index 095d784ed0c83a8e50b545e52f01db7f5e2c360d..47548456e28e5457ab692112e3aeb35294504e3a 100644 (file)
@@ -1,3 +1,19 @@
+2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Renaming some parameters passed to DB-related methods to better
+        indicate their purpose.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31449
+
+        * public/WebKitClient.h:
+        * src/ChromiumBridge.cpp:
+        (WebCore::ChromiumBridge::databaseOpenFile):
+        (WebCore::ChromiumBridge::databaseDeleteFile):
+        (WebCore::ChromiumBridge::databaseGetFileAttributes):
+        (WebCore::ChromiumBridge::databaseGetFileSize):
+
 2009-11-12  Adam Barth  <abarth>
 
         Reviewed by Dimitri Glazkov.
index 6ff6aa6b1b400b1582a52e0f3a93048d6d067943..3a1e0553942139abd3cf5ff1c4094f8c5e67f9b9 100644 (file)
@@ -137,16 +137,16 @@ public:
     // Opens a database file; dirHandle should be 0 if the caller does not need
     // a handle to the directory containing this file
     virtual FileHandle databaseOpenFile(
-        const WebString& fileName, int desiredFlags, FileHandle* dirHandle) = 0;
+        const WebString& vfsFileName, int desiredFlags, FileHandle* dirHandle) = 0;
 
     // Deletes a database file and returns the error code
-    virtual int databaseDeleteFile(const WebString& fileName, bool syncDir) = 0;
+    virtual int databaseDeleteFile(const WebString& vfsFileName, bool syncDir) = 0;
 
     // Returns the attributes of the given database file
-    virtual long databaseGetFileAttributes(const WebString& fileName) = 0;
+    virtual long databaseGetFileAttributes(const WebString& vfsFileName) = 0;
 
     // Returns the size of the given database file
-    virtual long long databaseGetFileSize(const WebString& fileName) = 0;
+    virtual long long databaseGetFileSize(const WebString& vfsFileName) = 0;
 
 
     // Keygen --------------------------------------------------------------
index 8d63c5fe84cee61bebd55ad9a81c2c980e074414..93d92bad9e683fac2383cbcf4348134c61898ec5 100644 (file)
@@ -306,24 +306,24 @@ String ChromiumBridge::getFontFamilyForCharacters(const UChar* characters, size_
 // HTML5 DB -------------------------------------------------------------------
 
 #if ENABLE(DATABASE)
-PlatformFileHandle ChromiumBridge::databaseOpenFile(const String& fileName, int desiredFlags, PlatformFileHandle* dirHandle)
+PlatformFileHandle ChromiumBridge::databaseOpenFile(const String& vfsFileName, int desiredFlags, PlatformFileHandle* dirHandle)
 {
-    return webKitClient()->databaseOpenFile(WebString(fileName), desiredFlags, dirHandle);
+    return webKitClient()->databaseOpenFile(WebString(vfsFileName), desiredFlags, dirHandle);
 }
 
-int ChromiumBridge::databaseDeleteFile(const String& fileName, bool syncDir)
+int ChromiumBridge::databaseDeleteFile(const String& vfsFileName, bool syncDir)
 {
-    return webKitClient()->databaseDeleteFile(WebString(fileName), syncDir);
+    return webKitClient()->databaseDeleteFile(WebString(vfsFileName), syncDir);
 }
 
-long ChromiumBridge::databaseGetFileAttributes(const String& fileName)
+long ChromiumBridge::databaseGetFileAttributes(const String& vfsFileName)
 {
-    return webKitClient()->databaseGetFileAttributes(WebString(fileName));
+    return webKitClient()->databaseGetFileAttributes(WebString(vfsFileName));
 }
 
-long long ChromiumBridge::databaseGetFileSize(const String& fileName)
+long long ChromiumBridge::databaseGetFileSize(const String& vfsFileName)
 {
-    return webKitClient()->databaseGetFileSize(WebString(fileName));
+    return webKitClient()->databaseGetFileSize(WebString(vfsFileName));
 }
 #endif