Reviewed by Brady.
authorap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Jan 2008 18:47:59 +0000 (18:47 +0000)
committerap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Jan 2008 18:47:59 +0000 (18:47 +0000)
        Database origin tracking is broken.

        * storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::populateOrigins):
        Move reading from statement back into the loop (broken in r29386).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/storage/DatabaseTracker.cpp

index 346ee4476055221c56ed38b2a1ce875a89bf57b6..201957a28c2e5e52e5aee2a9deadfc864261e9a6 100644 (file)
@@ -1,3 +1,12 @@
+2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Brady.
+
+        Database origin tracking is broken.
+
+        * storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::populateOrigins):
+        Move reading from statement back into the loop (broken in r29386).
+
 2008-01-18  Marius Storm-Olsen  <marius@trolltech.com>
 
         Reviewed by Simon Hausmann <hausmann@webkit.org>.
index 21906d954c1ab7fad4b589e41f16890c28c1dc34..ee29eca5b85921bcd536d2d0cc413db22099ad8f 100644 (file)
@@ -274,9 +274,10 @@ void DatabaseTracker::populateOrigins()
         return;
 
     int result;
-    RefPtr<SecurityOrigin> origin = SecurityOrigin::createFromIdentifier(statement.getColumnText16(0));
-    while ((result = statement.step()) == SQLResultRow)
+    while ((result = statement.step()) == SQLResultRow) {
+        RefPtr<SecurityOrigin> origin = SecurityOrigin::createFromIdentifier(statement.getColumnText16(0));
         m_originQuotaMap->set(origin.get(), statement.getColumnInt64(1));
+    }
 
     if (result != SQLResultDone)
         LOG_ERROR("Failed to read in all origins from the database");