Made show-pretty-diff work when the input path contains spaces.

Reviewed by Anders Carlsson.

* Scripts/show-pretty-diff:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 7bd2cae180d3bdc7d255e0d39c5b2c5547355071..f66da07e5b76441294918793ccf69c7f86017aa6 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,11 @@
+2011-11-06  Dan Bernstein  <mitz@apple.com>
+
+        Made show-pretty-diff work when the input path contains spaces.
+
+        Reviewed by Anders Carlsson.
+
+        * Scripts/show-pretty-diff:
+
 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
 
         [chromium] Use the security origin instead of the URL when checking notification permissions

diff --git a/Tools/Scripts/show-pretty-diff b/Tools/Scripts/show-pretty-diff
index c7f4d2bbd8cf7a20e31bcd9b5346b9d67711b792..be426c0145e23f81386cf841899f3c7a961ae579 100755 (executable)
--- a/Tools/Scripts/show-pretty-diff
+++ b/Tools/Scripts/show-pretty-diff
@@ -64,7 +64,7 @@ my $prettyPatchDir = sourceDir() . "/Websites/bugs.webkit.org/PrettyPatch/";
 my $prettyPatchTool = sourceDir() . "/Websites/bugs.webkit.org/PrettyPatch/prettify.rb";
 
 my $pathToPrettify = "ruby -I " . sourceDir() . "/Websites/bugs.webkit.org/PrettyPatch/ " . sourceDir() . "/Websites/bugs.webkit.org/PrettyPatch/prettify.rb";
-system "$pathToPrettify $inputPath > $prettydiffPath";
+system "$pathToPrettify " . quotemeta($inputPath) . " > $prettydiffPath";
 
 if (isAppleMacWebKit()) {
     system "open", $prettydiffPath;