Reviewed by me.
authorharrison <harrison@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 5 May 2005 17:01:07 +0000 (17:01 +0000)
committerharrison <harrison@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 5 May 2005 17:01:07 +0000 (17:01 +0000)
        Restore fixed setEndingSelection.  Fixed method was ifdef'd out
        because change was at end of Tiger development, but method is
        unused.  You just can never be _too_ safe.

        * khtml/editing/htmlediting.cpp:
        (khtml::EditCommandPtr::setEndingSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/editing/htmlediting.cpp

index b10bc8b4f0ba34b6f6ff6b55f8b5cb2b53654d8e..3782993e8fb4936f90d576a89510367352bbf2fd 100644 (file)
@@ -1,3 +1,14 @@
+2005-05-05  David Harrison  <harrison@apple.com>
+
+        Reviewed by me.
+
+        Restore fixed setEndingSelection.  Fixed method was ifdef'd out
+        because change was at end of Tiger development, but method is
+        unused.  You just can never be _too_ safe.
+        
+        * khtml/editing/htmlediting.cpp:
+        (khtml::EditCommandPtr::setEndingSelection):
+
 2005-05-02  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Vicki.
 2005-05-02  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Vicki.
index c097d7d36961a9b5da5802eb53ac5bf5b5fcfdbf..eb5355f1a10f36618537353ef1665954f269fd31 100644 (file)
@@ -363,16 +363,11 @@ void EditCommandPtr::setEndingSelection(const Selection &s) const
     get()->setEndingSelection(s);
 }
 
     get()->setEndingSelection(s);
 }
 
-#if 0
-// Implementation mistakenly used get()->setStartingSelection(), but it is
-// too late in Tiger to change, even though this method is unused.  Safest, then,
-// to fix but comment out until post-Tiger.
 void EditCommandPtr::setEndingSelection(const VisiblePosition &p) const
 {
     IF_IMPL_NULL_RETURN;
     get()->setEndingSelection(p);
 }
 void EditCommandPtr::setEndingSelection(const VisiblePosition &p) const
 {
     IF_IMPL_NULL_RETURN;
     get()->setEndingSelection(p);
 }
-#endif
 
 void EditCommandPtr::setEndingSelection(const Position &p, EAffinity affinity) const
 {
 
 void EditCommandPtr::setEndingSelection(const Position &p, EAffinity affinity) const
 {