2006-09-24 Eric Seidel <eric@eseidel.com>
authoreseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Sep 2006 02:35:09 +0000 (02:35 +0000)
committereseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Sep 2006 02:35:09 +0000 (02:35 +0000)
        Reviewed by beth.

        Browsers disagree on behavior for an invalid fill
        http://bugzilla.opendarwin.org/show_bug.cgi?id=11017

        * svg/custom/invalid-fill-expected.checksum: Added.
        * svg/custom/invalid-fill-expected.png: Added.
        * svg/custom/invalid-fill-expected.txt: Added.
        * svg/custom/invalid-fill.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/svg/custom/invalid-fill-expected.checksum [new file with mode: 0644]
LayoutTests/svg/custom/invalid-fill-expected.png [new file with mode: 0644]
LayoutTests/svg/custom/invalid-fill-expected.txt [new file with mode: 0644]
LayoutTests/svg/custom/invalid-fill.svg [new file with mode: 0644]

index 5918b2d6e65297c3f9e3bdae1ac13c930aea4e65..b974a7c8cb09cd6831a067b1a27b473ba567f4d8 100644 (file)
@@ -1,3 +1,15 @@
+2006-09-24  Eric Seidel  <eric@eseidel.com>
+
+        Reviewed by beth.
+
+        Browsers disagree on behavior for an invalid fill
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=11017
+
+        * svg/custom/invalid-fill-expected.checksum: Added.
+        * svg/custom/invalid-fill-expected.png: Added.
+        * svg/custom/invalid-fill-expected.txt: Added.
+        * svg/custom/invalid-fill.svg: Added.
+
 2006-09-24  Eric Seidel  <eric@eseidel.com>
 
         Reviewed by hyatt.
diff --git a/LayoutTests/svg/custom/invalid-fill-expected.checksum b/LayoutTests/svg/custom/invalid-fill-expected.checksum
new file mode 100644 (file)
index 0000000..a1c53b4
--- /dev/null
@@ -0,0 +1 @@
+75b9edcc5ab52f142a4d753fe5e036ed
\ No newline at end of file
diff --git a/LayoutTests/svg/custom/invalid-fill-expected.png b/LayoutTests/svg/custom/invalid-fill-expected.png
new file mode 100644 (file)
index 0000000..0b9f59c
Binary files /dev/null and b/LayoutTests/svg/custom/invalid-fill-expected.png differ
diff --git a/LayoutTests/svg/custom/invalid-fill-expected.txt b/LayoutTests/svg/custom/invalid-fill-expected.txt
new file mode 100644 (file)
index 0000000..971ced1
--- /dev/null
@@ -0,0 +1,17 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+    KCanvasContainer {svg} at (0,0) size 100x100
+      KCanvasContainer {g} at (0,0) size 100x100
+        KCanvasItem {rect} at (0,0) size 100x100 [fill={[type=SOLID] [color=#008000]}] [data="M0.00,0.00L100.00,0.00L100.00,100.00L0.00,100.00"]
+        KCanvasItem {rect} at (0,0) size 100x100 [data="M0.00,0.00L100.00,0.00L100.00,100.00L0.00,100.00"]
+        KCanvasContainer {g} at (0,0) size 0x0
+          RenderSVGText {text} at (0,0) size 800x18
+            RenderText {#text} at (0,0) size 667x18
+              text run at (0,0) width 667: "SVG 1.1 FULL says there should be a \"highly perceivable error\" message when an invalid fill url is used."
+          RenderSVGText {text} at (0,0) size 800x18
+            RenderText {#text} at (0,0) size 468x18
+              text run at (0,0) width 468: "Browsers don't display such an error, instead use some sort of fill-fallback."
+          RenderSVGText {text} at (0,0) size 800x18
+            RenderText {#text} at (0,0) size 636x18
+              text run at (0,0) width 561: "Opera falls back to 'black' (default), Firefox to 'none', and Safari to 'none' (as of writing). "
+              text run at (561,0) width 75: "Bug 11017."
diff --git a/LayoutTests/svg/custom/invalid-fill.svg b/LayoutTests/svg/custom/invalid-fill.svg
new file mode 100644 (file)
index 0000000..e4ffd57
--- /dev/null
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg xmlns="http://www.w3.org/2000/svg">
+  <g fill="red">
+    <rect width="100" height="100" fill="green"/>
+    <rect width="100" height="100" fill="url(#notthere)"/>
+    <g fill="black">
+      <text x="10" y="130">SVG 1.1 FULL says there should be a "highly perceivable error" message when an invalid fill url is used.</text>
+      <text x="10" y="150">Browsers don't display such an error, instead use some sort of fill-fallback.</text>
+      <text x="10" y="170">Opera falls back to 'black' (default), Firefox to 'none', and Safari to 'none' (as of writing).  Bug 11017.</text>
+    </g>
+  </g>
+</svg>