Reviewed by Kevin.

	<rdar://problem/3725467> REGRESSION(140-142) nothing displayed at http://Ye-Olde-Movies.tripod.com
	<rdar://problem/3599494> REGRESSION (100-125): Frame does not refresh until user clicks on browser.

        * khtml/rendering/render_frames.cpp:
        (RenderFrameSet::layout): When returning early because there are
	no children, make sure to mark self as no longer needing
	layout. Otherwise, when children are added, we'll fail to
	propagate childrenNeedLayout to our own parent! This is almost
	certainly a long-standing bug that was just masked by our old
	layout tomfoolery.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 58220ececccad2645a1b9c60cf9d67857799799d..63949730a463867d5c057fefe1d38ef479bc1c07 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,18 @@
+2004-07-22  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Kevin.
+
+       <rdar://problem/3725467> REGRESSION(140-142) nothing displayed at http://Ye-Olde-Movies.tripod.com
+       <rdar://problem/3599494> REGRESSION (100-125): Frame does not refresh until user clicks on browser.
+       
+        * khtml/rendering/render_frames.cpp:
+        (RenderFrameSet::layout): When returning early because there are
+       no children, make sure to mark self as no longer needing
+       layout. Otherwise, when children are added, we'll fail to
+       propagate childrenNeedLayout to our own parent! This is almost
+       certainly a long-standing bug that was just masked by our old
+       layout tomfoolery.
+
 2004-07-22  Kevin Decker  <kdecker@apple.com>
 
        Reviewed by Darin

diff --git a/WebCore/khtml/rendering/render_frames.cpp b/WebCore/khtml/rendering/render_frames.cpp
index 2a702b329c22960f3b47e319bc309ebc5a82b331..e5238246b7e550e6761c1db902562762a0702c82 100644 (file)
--- a/WebCore/khtml/rendering/render_frames.cpp
+++ b/WebCore/khtml/rendering/render_frames.cpp
@@ -218,7 +218,7 @@ void RenderFrameSet::layout( )
 
     RenderObject *child = firstChild();
     if ( !child )
-      return;
+       goto end2;
 
     if(!m_hSplitVar && !m_vSplitVar)
     {