WebCore:
authoraliceli1 <aliceli1@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 Oct 2007 23:29:09 +0000 (23:29 +0000)
committeraliceli1 <aliceli1@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 Oct 2007 23:29:09 +0000 (23:29 +0000)
        Reviewed by Oliver.

        Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows

        * page/win/EventHandlerWin.cpp:
        (WebCore::EventHandler::passMouseMoveEventToSubframe):
        Some mouse move events are actually drags, which on mac return early from this function.
        Adding the same logic to its Windows equivalent.

WebKitTools:

        Reviewed by Oliver.

        Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows

        Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
        replay the saved events when we're still processing the mousedown that starts the drag
        * DumpRenderTree/win/EventSender.cpp:
        (doMouseMove):
        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::doDragDrop):

LayoutTests:

        Removing fixed test

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/win/Skipped
WebCore/ChangeLog
WebCore/page/win/EventHandlerWin.cpp
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/win/EventSender.cpp
WebKitTools/DumpRenderTree/win/UIDelegate.cpp

index ede2c21ecee7d97cbd439a0b43294e214d7672e0..ea918aab8f29b192d305a1540c53fadcc58d0d82 100644 (file)
@@ -1,3 +1,9 @@
+2007-10-24  Alice Liu  <alice.liu@apple.com>
+
+        Removing fixed test
+
+        * platform/win/Skipped:
+
 2007-10-24  Eric Seidel  <eric@webkit.org>
 
         Reviewed by Maciej.
index d091f212fa12ce2d289744be85963fca8e416193..41258be4ad6ef0c966caa0ec914d5b82e4f73b8f 100644 (file)
@@ -415,10 +415,6 @@ http/tests/security/cross-frame-access-protocol.html
 # Reports large negative numbers for screenLeft and screenTop <rdar://problem/5382579>
 http/tests/security/cross-frame-access-put.html
 
-#rdar://problem/5410959 editing/selection/drag-to-contenteditable-iframe.html fails on Windows
-editing/selection/drag-to-contenteditable-iframe.html
-
-
 # <rdar://problem/5463489> A number of layout tests use textInputController for operations that should be crossplatform
 editing/deleting/5300379.html
 editing/deleting/delete-to-end-of-paragraph.html
index 11873cb5bde8c00e4dc5855d556801a411965d5a..4250f20d6f110dd9e395ba6f33c5a6559ac16960 100644 (file)
@@ -1,3 +1,14 @@
+2007-10-24  Alice Liu  <alice.liu@apple.com>
+
+        Reviewed by Oliver.
+
+        Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
+        
+        * page/win/EventHandlerWin.cpp:
+        (WebCore::EventHandler::passMouseMoveEventToSubframe):
+        Some mouse move events are actually drags, which on mac return early from this function.
+        Adding the same logic to its Windows equivalent.  
+
 2007-10-24  Brady Eidson  <beidson@apple.com>
 
         Reviewed by Anders
index c8020f39654aa367a8d3c0370d6a283be7e28c5f..5e349e34d3f77db3de50480e05c4253cfbd6d6e7 100644 (file)
@@ -52,6 +52,8 @@ bool EventHandler::passMousePressEventToSubframe(MouseEventWithHitTestResults& m
 
 bool EventHandler::passMouseMoveEventToSubframe(MouseEventWithHitTestResults& mev, Frame* subframe, HitTestResult* hoveredNode)
 {
+    if (m_mouseDownMayStartDrag && !m_mouseDownWasInSubframe)
+        return false;
     subframe->eventHandler()->handleMouseMoveEvent(mev.event(), hoveredNode);
     return true;
 }
index a1295f6a6b0cd7031662c1eb2113a59cd6ed94e1..8de5fe069ea3312daa4cd97fb09bc8552ad179a6 100644 (file)
@@ -1,3 +1,16 @@
+2007-10-24  Alice Liu  <alice.liu@apple.com>
+
+        Reviewed by Oliver.
+
+        Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
+
+        Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
+        replay the saved events when we're still processing the mousedown that starts the drag
+        * DumpRenderTree/win/EventSender.cpp:
+        (doMouseMove):
+        * DumpRenderTree/win/UIDelegate.cpp:
+        (UIDelegate::doDragDrop):
+
 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
 
         Reviewed by Sam, Steve and Darin.
index 0547dc5e1eb9e67ea6d0d550bccca8f39f277436..e27423e01ae69557168eadb7a87fc4c243b9260e 100644 (file)
@@ -186,6 +186,7 @@ static void doMouseMove(MSG msg)
                 didDragEnter = true;
             }
             draggingInfo->dropSource()->GiveFeedback(effect);
+            replaySavedEvents();
         }
     }
 }
index 70fc3e812225f0de9b2e7b5c63e094dd04d48a70..b5f008c44cfe990ac4641919c9401990e7eec0ed 100755 (executable)
@@ -152,8 +152,6 @@ HRESULT STDMETHODCALLTYPE UIDelegate::doDragDrop(
 
     draggingInfo = new DraggingInfo(object, source);
 
-    replaySavedEvents();
-
     return S_OK;
 }