Reviewed by John and Adam.
authoroliver <oliver@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Aug 2007 05:02:23 +0000 (05:02 +0000)
committeroliver <oliver@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Aug 2007 05:02:23 +0000 (05:02 +0000)
        WebDataSource::response can legitimately have a null response, so we
        must check that case.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
        (dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp

index 75d13580d1692c28e5fac59a6fbec63011b56026..59371bc1982e6208d040407018526252fe34bf5f 100644 (file)
@@ -1,3 +1,13 @@
+2007-08-22  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by John and Adam.
+        
+        WebDataSource::response can legitimately have a null response, so we
+        must check that case.
+
+        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
+        (dump):
+
 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
 
         Reviewed by Geof.
index 268016edc8d2a8c5a53f063e73f472e34255ca6a..ccb4f1d6b05fc262285177eb31df9527f67d9937 100644 (file)
@@ -466,7 +466,7 @@ void dump()
     COMPtr<IWebDataSource> dataSource;
     if (SUCCEEDED(frame->dataSource(&dataSource))) {
         COMPtr<IWebURLResponse> response;
-        if (SUCCEEDED(dataSource->response(&response))) {
+        if (SUCCEEDED(dataSource->response(&response)) && response) {
             BSTR mimeType;
             if (SUCCEEDED(response->MIMEType(&mimeType)))
                 dumpAsText |= !_tcscmp(mimeType, TEXT("text/plain"));