Unreviewed, only ignoring chatty style errors.
check-webkit-style: WebKit needs a python style checker
https://bugs.webkit.org/show_bug.cgi?id=33639
Remove the 79 char line limit by ignoring
pep8/E501. Because we have our own report_error
implementation we have to ignore E501 by hand
instead of passing --ignore=E501.
Right now over 1400 lines of our existing python
fail E501 so this rule just generates needless noise.
The rest of WebKit has no wrapping rule so it makes
little sense for our Python to differ here.
* Scripts/webkitpy/style/processors/python.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2010-04-01 Eric Seidel <eric@webkit.org>
+
+ Unreviewed, only ignoring chatty style errors.
+
+ check-webkit-style: WebKit needs a python style checker
+ https://bugs.webkit.org/show_bug.cgi?id=33639
+
+ Remove the 79 char line limit by ignoring
+ pep8/E501. Because we have our own report_error
+ implementation we have to ignore E501 by hand
+ instead of passing --ignore=E501.
+
+ Right now over 1400 lines of our existing python
+ fail E501 so this rule just generates needless noise.
+ The rest of WebKit has no wrapping rule so it makes
+ little sense for our Python to differ here.
+
+ * Scripts/webkitpy/style/processors/python.py:
+
2010-04-01 Adam Barth <abarth@webkit.org>
Unreviewed. Add cmarrin's IRC nickname.
def process(self, lines):
# Initialize pep8.options, which is necessary for
# Checker.check_all() to execute.
- pep8.process_options(arglist=[self._file_path])
+ pep8.process_options(arglist=[self._file_path])
checker = pep8.Checker(self._file_path)
def _pep8_handle_error(line_number, offset, text, check):
pep8_code = text[:4]
pep8_message = text[5:]
+ # We ignore PEP8/E501 -- line limit of 79 characters. Most of our
+ # python code fails E501 and the rest of WebKit has no wrap limit.
+ if pep8_code == "E501":
+ return
+
category = "pep8/" + pep8_code
self._handle_style_error(line_number, category, 5, pep8_message)