2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Apr 2011 09:45:10 +0000 (09:45 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Apr 2011 09:45:10 +0000 (09:45 +0000)
        Unreviewed, rolling out r84112.
        http://trac.webkit.org/changeset/84112
        https://bugs.webkit.org/show_bug.cgi?id=58770

        Chromium linux layout tests are broken. (Requested by loislo2
        on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

index f4b51c354e9bacb193cfa7378c2ec44200ef25b4..667fdf1f6d6e75132b1e61f6f64254a5ceafae4f 100644 (file)
@@ -1,3 +1,15 @@
+2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r84112.
+        http://trac.webkit.org/changeset/84112
+        https://bugs.webkit.org/show_bug.cgi?id=58770
+
+        Chromium linux layout tests are broken. (Requested by loislo2
+        on #webkit).
+
+        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
+        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
+
 2011-04-17  Daniel Bates  <dbates@webkit.org>
 
         Reviewed by Eric Seidel and Adam Barth.
index bc8301083c45af82ab4ee407d3d1c2f4a0cabebe..eeb98905d26c8e05731a144f234543a23525afef 100644 (file)
@@ -43,9 +43,6 @@ def write_test_result(port, filename, driver_output,
     checksums_mismatch_but_images_are_same = False
     imagehash_mismatch_failure = None
     writer = TestResultWriter(port, root_output_dir, filename)
-    if driver_output.error:
-        writer.write_stderr(driver_output.error)
-
     for failure in failures:
         # FIXME: Instead of this long 'if' block, each failure class might
         # have a responsibility for writing a test result.
@@ -157,12 +154,6 @@ class TestResultWriter(object):
         if expected is not None:
             fs.write_binary_file(expected_filename, expected)
 
-    def write_stderr(self, error):
-        fs = self._port._filesystem
-        filename = self.output_filename("-stderr.txt")
-        fs.maybe_make_directory(fs.dirname(filename))
-        fs.write_text_file(filename, error)
-
     def write_crash_report(self, error):
         """Write crash information."""
         fs = self._port._filesystem
index 9705ffbb4762a204d10ce812d82940b8a812e293..6f39a92070853657e23f124e6d0db1bf25d085b3 100644 (file)
@@ -341,12 +341,6 @@ class MainTest(unittest.TestCase):
         tests_run = get_tests_run(['failures/expected/keybaord.html'], tests_included=True, flatten_batches=True)
         self.assertEquals([], tests_run)
 
-    def test_stderr_is_saved(self):
-        fs = port.unit_test_filesystem()
-        self.assertTrue(passing_run(filesystem=fs))
-        self.assertEquals(fs.read_text_file('/tmp/layout-test-results/passes/error-stderr.txt'),
-                          'stuff going to stderr')
-
     def test_test_list(self):
         fs = port.unit_test_filesystem()
         filename = '/tmp/foo.txt'