Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6962
          REGRESSION: www.usa.phillips.com crashes due to <param> with no name

        Test: fast/replaced/object-param-no-name.html

        * rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
        Check for empty name, and skip processing the name/value of that <param> element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 2e829470049bc7e8cf96dba29aec3dbd1bc4ad3e..df5cd951e73fa4ca4976179398610de1b399cda9 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2006-02-05  Darin Adler  <darin@apple.com>
+
+        Reviewed by Maciej.
+
+        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6962
+          REGRESSION: www.usa.phillips.com crashes due to <param> with no name
+
+        Test: fast/replaced/object-param-no-name.html
+
+        * rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
+        Check for empty name, and skip processing the name/value of that <param> element.
+
 2006-02-05  Darin Adler  <darin@apple.com>
 
         - rolled out Maciej's event cleanup patch, which is causing problems

diff --git a/WebCore/rendering/render_frames.cpp b/WebCore/rendering/render_frames.cpp
index 040c2736ebfae3d1a2717fdc11db721c2a75866a..86f75a6396627f52e7981a3bfce69fcc0b918fff 100644 (file)
--- a/WebCore/rendering/render_frames.cpp
+++ b/WebCore/rendering/render_frames.cpp
@@ -850,7 +850,7 @@ void RenderPartObject::updateWidget()
                       serviceType = serviceType.left(pos);
                   }
               }
-              if (!embed) {
+              if (!embed && !name.isEmpty()) {
                   uniqueParamNames.add(p->name().impl());
                   paramNames.append(p->name().qstring());
                   paramValues.append(p->value().qstring());