Terminology change in execCommand command identifiers. Specifically, the name of
"InsertNewline" command has been changed to "InsertLineBreak". This matches the
terminology used by AppKit. It is also more accurate, since the insertion of a
"br" element is what the command does. The inspiration for this change is so the
-insertNewline AppKit method can be mapped to insert a new "div" element in
a document and avoid ambiguity with what the javascript editing command does.
* khtml/editing/jsediting.cpp
* layout-tests/editing/deleting/delete-tab-004.html
* layout-tests/editing/editing.js
* layout-tests/editing/inserting/insert-
3654864-fix.html
* layout-tests/editing/inserting/insert-
3659587-fix.html
* layout-tests/editing/inserting/insert-
3775316-fix.html
* layout-tests/editing/inserting/insert-
3800346-fix.html
* layout-tests/editing/inserting/insert-br-001.html
* layout-tests/editing/inserting/insert-br-002.html
* layout-tests/editing/inserting/insert-br-003.html
* layout-tests/editing/inserting/insert-br-004.html
* layout-tests/editing/inserting/insert-br-005.html
* layout-tests/editing/inserting/insert-br-006.html
* layout-tests/editing/inserting/insert-br-007.html
* layout-tests/editing/inserting/insert-br-008.html
* layout-tests/editing/inserting/insert-tab-004.html
* layout-tests/editing/inserting/insert-text-with-newlines.html
* layout-tests/editing/pasteboard/paste-text-010.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
<script>
function editingTest() {
- insertNewlineCommand();
+ insertLineBreakCommand();
typeCharacterCommand('\t');
typeCharacterCommand('\t');
for (i = 0; i < 4; i++)
//-------------------------------------------------------------------------------------------------------
-function execInsertNewlineCommand() {
- document.execCommand("InsertNewline");
+function execInsertLineBreakCommand() {
+ document.execCommand("InsertLineBreak");
}
-function insertNewlineCommand() {
+function insertLineBreakCommand() {
if (commandDelay > 0) {
- window.setTimeout(execInsertNewlineCommand, commandCount * commandDelay);
+ window.setTimeout(execInsertLineBreakCommand, commandCount * commandDelay);
commandCount++;
}
else {
- execInsertNewlineCommand();
+ execInsertLineBreakCommand();
}
}
function editingTest() {
selectAllCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
for (i = 0; i < 3; i++) {
typeCharacterCommand();
}
for (i = 0; i < 3; i++) {
typeCharacterCommand();
}
- insertNewlineCommand();
+ insertLineBreakCommand();
for (i = 0; i < 3; i++) {
typeCharacterCommand();
}
function editingTest() {
moveSelectionForwardByCharacterCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
typeCharacterCommand();
selectAllCommand();
deleteCommand();
typeCharacterCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
typeCharacterCommand();
}
for (i = 0; i < 15; i++)
moveSelectionForwardByCharacterCommand();
for (i = 0; i < 3; i++)
- insertNewlineCommand();
+ insertLineBreakCommand();
}
</script>
function editingTest() {
selectAllCommand();
moveSelectionForwardByCharacterCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
typeCharacterCommand();
}
function editingTest() {
for (i = 0; i < 4; i++)
moveSelectionForwardByCharacterCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
typeCharacterCommand();
}
function editingTest() {
for (i = 0; i < 4; i++)
moveSelectionForwardByCharacterCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
typeCharacterCommand();
}
function editingTest() {
for (i = 0; i < 3; i++)
moveSelectionForwardByCharacterCommand();
- insertNewlineCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
+ insertLineBreakCommand();
}
</script>
function editingTest() {
for (i = 0; i < 3; i++)
moveSelectionForwardByCharacterCommand();
- insertNewlineCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
+ insertLineBreakCommand();
typeCharacterCommand();
}
<script>
function editingTest() {
- insertNewlineCommand();
+ insertLineBreakCommand();
typeCharacterCommand();
}
function editingTest() {
for (i = 0; i < 3; i++)
moveSelectionForwardByCharacterCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
}
</script>
<script>
function editingTest() {
- insertNewlineCommand();
+ insertLineBreakCommand();
typeCharacterCommand(" ");
}
<script>
function editingTest() {
- insertNewlineCommand();
+ insertLineBreakCommand();
typeCharacterCommand('\t');
}
+
<html>
<head>
function editingTest() {
moveNSpacesAndType(4);
- insertNewlineCommand();
+ insertLineBreakCommand();
moveNSpacesAndType(4);
- insertNewlineCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
+ insertLineBreakCommand();
moveNSpacesAndType(4);
}
+
<html>
<head>
extendSelectionForwardByCharacterCommand();
copyCommand();
moveSelectionForwardByCharacterCommand();
- insertNewlineCommand();
- insertNewlineCommand();
+ insertLineBreakCommand();
+ insertLineBreakCommand();
pasteCommand();
pasteCommand();
}
+2004-12-03 Ken Kocienda <kocienda@apple.com>
+
+ Reviewed by John
+
+ Terminology change in execCommand command identifiers. Specifically, the name of
+ "InsertNewline" command has been changed to "InsertLineBreak". This matches the
+ terminology used by AppKit. It is also more accurate, since the insertion of a
+ "br" element is what the command does. The inspiration for this change is so the
+ -insertNewline AppKit method can be mapped to insert a new "div" element in
+ a document and avoid ambiguity with what the javascript editing command does.
+
+ * khtml/editing/jsediting.cpp
+ * layout-tests/editing/deleting/delete-tab-004.html
+ * layout-tests/editing/editing.js
+ * layout-tests/editing/inserting/insert-3654864-fix.html
+ * layout-tests/editing/inserting/insert-3659587-fix.html
+ * layout-tests/editing/inserting/insert-3775316-fix.html
+ * layout-tests/editing/inserting/insert-3800346-fix.html
+ * layout-tests/editing/inserting/insert-br-001.html
+ * layout-tests/editing/inserting/insert-br-002.html
+ * layout-tests/editing/inserting/insert-br-003.html
+ * layout-tests/editing/inserting/insert-br-004.html
+ * layout-tests/editing/inserting/insert-br-005.html
+ * layout-tests/editing/inserting/insert-br-006.html
+ * layout-tests/editing/inserting/insert-br-007.html
+ * layout-tests/editing/inserting/insert-br-008.html
+ * layout-tests/editing/inserting/insert-tab-004.html
+ * layout-tests/editing/inserting/insert-text-with-newlines.html
+ * layout-tests/editing/pasteboard/paste-text-010.html
+
2004-12-02 Ken Kocienda <kocienda@apple.com>
Reviewed by John
return false;
}
-bool execInsertNewline(KHTMLPart *part, bool userInterface, const DOMString &value)
+bool execInsertLineBreak(KHTMLPart *part, bool userInterface, const DOMString &value)
{
TypingCommand::insertLineBreak(part->xmlDocImpl());
return true;
{ "FontSize", { execFontSize, enabledAnySelection, stateNone, valueFontSize } },
{ "ForeColor", { execForeColor, enabledAnySelection, stateNone, valueForeColor } },
{ "Indent", { execIndent, enabledAnySelection, stateNone, valueNull } },
- { "InsertNewline", { execInsertNewline, enabledAnySelection, stateNone, valueNull } },
+ { "InsertLineBreak", { execInsertLineBreak, enabledAnySelection, stateNone, valueNull } },
{ "InsertParagraph", { execInsertParagraph, enabledAnySelection, stateNone, valueNull } },
{ "InsertText", { execInsertText, enabledAnySelection, stateNone, valueNull } },
{ "Italic", { execItalic, enabledAnySelection, stateItalic, valueNull } },