Web Inspector: Fix front-end compilation warnings related to WebInspector.SidebarPane

https://bugs.webkit.org/show_bug.cgi?id=109259

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.Proxy):
* inspector/front-end/SidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 4fb919bd0eebc28876247ba0d14b4a1a31588fc1..c49b42da659ee898172bfcdaad77b64b37162fae 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,14 @@
+2013-02-07  Vladislav Kaznacheev  <kaznacheev@chromium.org>
+
+        Web Inspector: Fix front-end compilation warnings related to WebInspector.SidebarPane
+        https://bugs.webkit.org/show_bug.cgi?id=109259
+
+        Reviewed by Vsevolod Vlasov.
+
+        * inspector/front-end/DOMBreakpointsSidebarPane.js:
+        (WebInspector.DOMBreakpointsSidebarPane.Proxy):
+        * inspector/front-end/SidebarPane.js:
+
 2013-02-07  Kentaro Hara  <haraken@chromium.org>
 
         [V8] enum V8HiddenPropertyCreationType is not used

diff --git a/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js b/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js
index afbaab8b929f9bedab11ebf119ea010c4e7218e3..7501429578511a4a87338a486f06a40665d5c84c 100644 (file)
--- a/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js
+++ b/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js
@@ -354,7 +354,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
  */
 WebInspector.DOMBreakpointsSidebarPane.Proxy = function(pane, panel)
 {
-    WebInspector.View._assert(!pane.titleElement.firstChild);
+    WebInspector.View._assert(!pane.titleElement.firstChild, "Cannot create proxy for a sidebar pane with a toolbar");
 
     WebInspector.SidebarPane.call(this, pane.title());
 

diff --git a/Source/WebCore/inspector/front-end/SidebarPane.js b/Source/WebCore/inspector/front-end/SidebarPane.js
index da7c6a1d439808a3c00f12702d4a8b4f94af1ea2..784c0e3702aaf412ac2f10ac64f79eff7691cc04 100644 (file)
--- a/Source/WebCore/inspector/front-end/SidebarPane.js
+++ b/Source/WebCore/inspector/front-end/SidebarPane.js
@@ -85,7 +85,6 @@ WebInspector.SidebarPane.prototype = {
 
     /**
      * @param {function()} callback
-     * @return {boolean}
      */
     _setExpandCallback: function(callback)
     {