2011-02-17 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix escape handling in code review tool
        https://bugs.webkit.org/show_bug.cgi?id=54722

        This broke with http://trac.webkit.org/changeset/78948.
        Apparently jquery events get a wrapped object that
        does not expose keyIdentifier.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index a2c523566c961f33970ac99a0229981f4795690c..62936c57056990a7340d47db7d878cb75feb7574 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,16 @@
+2011-02-17  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        fix escape handling in code review tool
+        https://bugs.webkit.org/show_bug.cgi?id=54722
+
+        This broke with http://trac.webkit.org/changeset/78948.
+        Apparently jquery events get a wrapped object that
+        does not expose keyIdentifier.
+
+        * code-review.js:
+
 2011-02-17  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index bbfeba5131765738c55cc12f7816cb00ec6dad05..10651884dc3de66cdf97aa2296bc25004e3d18e9 100644 (file)
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -1387,8 +1387,8 @@ var CODE_REVIEW_UNITTEST;
   }
 
   $('textarea').live('keydown', function(e) {
-    var unicode_escape = 'U+001B';
-    if (e.keyIdentifier == unicode_escape)
+    var escape_key_code = 27;
+    if (e.keyCode == escape_key_code)
       handleEscapeKeyDownInTextarea(this);
   });