Implicitly dismissed DD popovers don't clear immediate action state, prematurely...
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Jan 2015 21:47:14 +0000 (21:47 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Jan 2015 21:47:14 +0000 (21:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=140088
<rdar://problem/19298391>

Reviewed by Anders Carlsson.

* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _menuItemForDataDetectedText]):
Instead of just tearing down the TextIndicator, clear all state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm

index 0c2a3d3a115a0ce5e9bfd98184892e0ae75da1a2..d9f3a80845d5be1e26d7050b3a8734054531b24e 100644 (file)
@@ -1,3 +1,15 @@
+2015-01-05  Timothy Horton  <timothy_horton@apple.com>
+
+        Implicitly dismissed DD popovers don't clear immediate action state, prematurely dismissing the next DD highlight
+        https://bugs.webkit.org/show_bug.cgi?id=140088
+        <rdar://problem/19298391>
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/mac/WKImmediateActionController.mm:
+        (-[WKImmediateActionController _menuItemForDataDetectedText]):
+        Instead of just tearing down the TextIndicator, clear all state.
+
 2015-01-05  Csaba Osztrogon√°c  <ossy@webkit.org>
 
         One more URTBF after r177917.
index 307642cb7fd6be6278e3592f49803449ac806802..8297fb19566719014f36f4b27cb87b4e856f4d49 100644 (file)
@@ -312,7 +312,7 @@ using namespace WebKit;
         page->send(Messages::WebPage::DataDetectorsDidChangeUI(overlayID));
     } interactionStoppedHandler:^() {
         page->send(Messages::WebPage::DataDetectorsDidHideUI(overlayID));
-        page->clearTextIndicator();
+        [self _clearImmediateActionState];
     }];
 
     [_currentActionContext setHighlightFrame:[_wkView.window convertRectToScreen:[_wkView convertRect:_hitTestResult.detectedDataBoundingBox toView:nil]]];