- changed these tests to be expected failures because I had to roll
out the fix to http://bugzilla.opendarwin.org/show_bug.cgi?id=6314
Unclosed <style> element in <head> makes page completely blank
* fast/js/exception-linenums-in-html-3-expected.txt:
* fast/js/exception-linenums-in-html-3-expected.png: Added.
* fast/js/exception-linenums-in-html-3-expected.checksum: Added.
* fast/js/missing-style-end-tag-js-expected.txt:
* fast/js/missing-style-end-tag-js-expected.png: Added.
* fast/js/missing-style-end-tag-js-expected.checksum: Added.
* fast/tokenizer/missing-style-end-tag-1-expected.checksum:
* fast/tokenizer/missing-style-end-tag-1-expected.png:
* fast/tokenizer/missing-style-end-tag-1-expected.txt:
* fast/tokenizer/missing-style-end-tag-2-expected.checksum:
* fast/tokenizer/missing-style-end-tag-2-expected.png:
* fast/tokenizer/missing-style-end-tag-2-expected.txt:
- added some missing pixel-test results
* tables/mozilla/marvin/backgr_layers-opacity-expected.checksum: Added.
* tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
* fast/dom/Element/class-attribute-whitespace-expected.png: Added.
* fast/canvas/patternfill-repeat-expected.png: Added.
WebCore:
- roll out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6314
Unclosed <style> element in <head> makes page completely blank
This fix was breaking major sites -- details in the bug report.
* khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
Removed the bug fix, added a FIXME about the <title> code that has
the same problem.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2006-03-19 Darin Adler <darin@apple.com>
+
+ - changed these tests to be expected failures because I had to roll
+ out the fix to http://bugzilla.opendarwin.org/show_bug.cgi?id=6314
+ Unclosed <style> element in <head> makes page completely blank
+
+ * fast/js/exception-linenums-in-html-3-expected.txt:
+ * fast/js/exception-linenums-in-html-3-expected.png: Added.
+ * fast/js/exception-linenums-in-html-3-expected.checksum: Added.
+
+ * fast/js/missing-style-end-tag-js-expected.txt:
+ * fast/js/missing-style-end-tag-js-expected.png: Added.
+ * fast/js/missing-style-end-tag-js-expected.checksum: Added.
+
+ * fast/tokenizer/missing-style-end-tag-1-expected.checksum:
+ * fast/tokenizer/missing-style-end-tag-1-expected.png:
+ * fast/tokenizer/missing-style-end-tag-1-expected.txt:
+ * fast/tokenizer/missing-style-end-tag-2-expected.checksum:
+ * fast/tokenizer/missing-style-end-tag-2-expected.png:
+ * fast/tokenizer/missing-style-end-tag-2-expected.txt:
+
+ - added some missing pixel-test results
+
+ * tables/mozilla/marvin/backgr_layers-opacity-expected.checksum: Added.
+ * tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
+ * fast/dom/Element/class-attribute-whitespace-expected.png: Added.
+ * fast/canvas/patternfill-repeat-expected.png: Added.
+
2006-03-18 David Carson <dacarson@gmail.com>
Reviewed by Darin.
--- /dev/null
+853de00567d121bea0b7bece66a5d61c
\ No newline at end of file
-This test exercises the source URL and line number that is embedded in JavaScript exceptions, which is displayed in places like the JavaScript console. It differs from exception-linenums-in-html-1.html in that it only works if Bugzilla Bug 6314 has been fixed.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS typeof e.sourceURL is "string"
-PASS e.line is 23
-PASS typeof e.sourceURL is "string"
-PASS e.line is 33
-PASS typeof e.sourceURL is "string"
-PASS e.line is 43
-PASS typeof e.sourceURL is "string"
-PASS e.line is 53
-PASS typeof e.sourceURL is "string"
-PASS e.line is 16
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+layer at (0,0) size 800x600
+ RenderCanvas at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
--- /dev/null
+853de00567d121bea0b7bece66a5d61c
\ No newline at end of file
-This test checks that the first <script> tag after an unclosed <style> tag is parsed correctly. Early versions of the patch for Bugzilla Bug 6314 did not reset a state variable properly, causing the first <script></script> tag in the document to contain everything after the <style> tag.
-
-This text should also be blue.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+layer at (0,0) size 800x600
+ RenderCanvas at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
-b2143a64532af6bc89a2baf5f5c82ee9
-\ No newline at end of file
+853de00567d121bea0b7bece66a5d61c
\ No newline at end of file
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x579
- RenderBlock {DIV} at (0,0) size 784x36
- RenderText {TEXT} at (0,0) size 779x36
- text run at (0,0) width 332: "This document is missing its </style> tag in its head. "
- text run at (332,0) width 447: "The tokenizer should retokenize this document after consuming all of it"
- text run at (0,18) width 504: "looking for the missing end tag, then let the parser clean up the missing tag. See "
- RenderInline {A} at (0,0) size 120x18 [color=#0000EE]
- RenderText {TEXT} at (504,18) size 120x18
- text run at (504,18) width 120: "Bugzilla Bug 6314"
- RenderText {TEXT} at (624,18) size 4x18
- text run at (624,18) width 4: "."
- RenderBlock {P} at (0,49) size 784x15
- RenderText {TEXT} at (0,0) size 280x15
- text run at (0,0) width 280: "This text should also be monospace."
+ RenderBody {BODY} at (8,8) size 784x584
-f8f76ddf9c676bfec58b9dff1580aaa2
-\ No newline at end of file
+853de00567d121bea0b7bece66a5d61c
\ No newline at end of file
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x579
- RenderBlock {DIV} at (0,0) size 784x36
- RenderText {TEXT} at (0,0) size 781x36
- text run at (0,0) width 334: "This document is missing its </style> tag in its body. "
- text run at (334,0) width 447: "The tokenizer should retokenize this document after consuming all of it"
- text run at (0,18) width 504: "looking for the missing end tag, then let the parser clean up the missing tag. See "
- RenderInline {A} at (0,0) size 120x18 [color=#0000EE]
- RenderText {TEXT} at (504,18) size 120x18
- text run at (504,18) width 120: "Bugzilla Bug 6314"
- RenderText {TEXT} at (624,18) size 4x18
- text run at (624,18) width 4: "."
- RenderBlock {P} at (0,49) size 784x15
- RenderText {TEXT} at (0,0) size 280x15
- text run at (0,0) width 280: "This text should also be monospace."
+ RenderBody {BODY} at (8,8) size 784x584
--- /dev/null
+23b08045480e5d81a5006ae190a09e2c
\ No newline at end of file
+2006-03-19 Darin Adler <darin@apple.com>
+
+ - roll out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6314
+ Unclosed <style> element in <head> makes page completely blank
+
+ This fix was breaking major sites -- details in the bug report.
+
+ * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
+ Removed the bug fix, added a FIXME about the <title> code that has
+ the same problem.
+
2006-03-18 David Carson <dacarson@gmail.com>
Test: fast/canvas/patternfill-repeat.html
if (beginTag) {
searchStopper = styleEnd;
searchStopperLen = 7;
- State savedState = state;
- SegmentedString savedSrc = src;
- long savedLineno = lineno;
state.setInStyle(true);
state = parseSpecial(src, state);
- if (state.inStyle() && src.isEmpty()) {
- // We just ate the rest of the document as the style #text node!
- // Reset the state then retokenize without special style handling.
- // Let the html parser clean up the missing </style> tag.
- state = savedState;
- src = savedSrc;
- lineno = savedLineno;
- scriptCodeSize = 0;
- }
}
} else if (tagName == textareaTag) {
if (beginTag) {
if (state.inTitle() && src.isEmpty()) {
// We just ate the rest of the document as the title #text node!
// Reset the state then retokenize without special title handling.
- // Let the html parser clean up the missing </title> tag.
+ // Let the parser clean up the missing </title> tag.
+ // FIXME: This is incorrect, because src.isEmpty() doesn't mean we're
+ // at the end of the document unless noMoreData is also true. We need
+ // to detect this case elsewhere, and save the state somewhere other
+ // than a local variable.
state = savedState;
src = savedSrc;
lineno = savedLineno;
git://git.webkit.org / WebKit-https.git / commitdiff
