Remove chartPointRadius from interactive chart component
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Nov 2015 20:40:26 +0000 (20:40 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Nov 2015 20:40:26 +0000 (20:40 +0000)
https://bugs.webkit.org/show_bug.cgi?id=151480

Reviewed by Darin Adler.

Replaced the parameter by CSS rules.

* public/v2/chart-pane.css:
(.chart .dot):
(.chart .dot.foreground):
(.chart .highlight):
(.chart .extent):
* public/v2/index.html:
* public/v2/interactive-chart.js:
(App.InteractiveChartComponent.Ember.Component.extend._constructGraphIfPossible):
(App.InteractiveChartComponent.Ember.Component.extend._highlightedItemsChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@192692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v2/chart-pane.css
Websites/perf.webkit.org/public/v2/index.html
Websites/perf.webkit.org/public/v2/interactive-chart.js

index c66c215..f9b7832 100644 (file)
@@ -1,5 +1,24 @@
 2015-11-20  Ryosuke Niwa  <rniwa@webkit.org>
 
+        Remove chartPointRadius from interactive chart component
+        https://bugs.webkit.org/show_bug.cgi?id=151480
+
+        Reviewed by Darin Adler.
+
+        Replaced the parameter by CSS rules.
+
+        * public/v2/chart-pane.css:
+        (.chart .dot):
+        (.chart .dot.foreground):
+        (.chart .highlight):
+        (.chart .extent):
+        * public/v2/index.html:
+        * public/v2/interactive-chart.js:
+        (App.InteractiveChartComponent.Ember.Component.extend._constructGraphIfPossible):
+        (App.InteractiveChartComponent.Ember.Component.extend._highlightedItemsChanged):
+
+2015-11-20  Ryosuke Niwa  <rniwa@webkit.org>
+
         Perf dashboard's runs API uses more than 128MB of memory
         https://bugs.webkit.org/show_bug.cgi?id=151478
 
index fc59414..fb3aeb3 100644 (file)
@@ -361,7 +361,9 @@ a.outlier-button.show g.hide-outlier-icon {
 .chart .dot {
     fill: #ccc;
     stroke: none;
+    r: 2px;
 }
+
 .chart .dot.foreground {
     fill: #666;
 }
@@ -437,6 +439,7 @@ a.outlier-button.show g.hide-outlier-icon {
     stroke: #f93;
     stroke-width: 2px;
     fill: none;
+    r: 3.6px;
 }
 
 .chart .extent {
index 8b11ece..0b3d561 100644 (file)
                             ranges=ranges
                             domain=mainPlotDomain
                             interactive=true
-                            chartPointRadius=2
                             currentItem=hoveredOrSelectedItem
                             currentTime=sharedTime
                             selectedItem=selectedItem
                         ranges=pane.ranges
                         domain=overviewDomain
                         interactive=true
-                        chartPointRadius=2
                         currentItem=pane.hoveredOrSelectedItem
                         selectedPoints=pane.selectedPoints
                         selection=timeRange
                     {{interactive-chart
                         chartData=referenceChart.data
                         domain=overviewDomain
-                        chartPointRadius=2
                         showYAxis=false
                         enableSelection=false
                         highlightedItems=referenceChart.highlightedItems}}
index 9a04540..143db31 100644 (file)
@@ -142,8 +142,7 @@ App.InteractiveChartComponent = Ember.Component.extend({
             .selectAll(".dot")
                 .data(this._currentTimeSeriesData)
             .enter().append("circle")
-                .attr("class", "dot" + foregroundClass)
-                .attr("r", this.get('chartPointRadius') || 1));
+                .attr("class", "dot" + foregroundClass));
 
         if (movingAverageIsVisible) {
             this._paths.push(this._clippedContainer
@@ -611,8 +610,7 @@ App.InteractiveChartComponent = Ember.Component.extend({
             .selectAll(".highlight")
                 .data(data)
             .enter().append("circle")
-                .attr("class", "highlight")
-                .attr("r", (this.get('chartPointRadius') || 1) * 1.8);
+                .attr("class", "highlight");
 
         this._domainChanged();
     }.observes('highlightedItems'),