Reviewed by Ken.
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 4 Dec 2004 01:56:05 +0000 (01:56 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 4 Dec 2004 01:56:05 +0000 (01:56 +0000)
        - fixed <rdar://problem/3889411> REGRESSION (125-172): repro crash in
        khtml::BackgroundLayer::cullEmptyLayers

        * khtml/rendering/render_style.cpp:
        (BackgroundLayer::cullEmptyLayers):
        added missing nil check

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/rendering/render_style.cpp

index 28578a8b55f216cc9f12e476ecd27fb030e09c10..5ac396ef60cb80418a209b2ab0bbb99fa4b735fd 100644 (file)
@@ -1,3 +1,14 @@
+2004-12-03  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Ken.
+        
+        - fixed <rdar://problem/3889411> REGRESSION (125-172): repro crash in 
+        khtml::BackgroundLayer::cullEmptyLayers
+
+        * khtml/rendering/render_style.cpp:
+        (BackgroundLayer::cullEmptyLayers):
+        added missing nil check
+
 === Safari-173 ===
 
 2004-12-03  Ken Kocienda  <kocienda@apple.com>
index de9f07725e674871af5c0218d6c5984d67778430..e5f4494bfe224a38177919540cc438a52937ac11 100644 (file)
@@ -228,7 +228,7 @@ void BackgroundLayer::cullEmptyLayers()
     BackgroundLayer *next;
     for (BackgroundLayer *p = this; p; p = next) {
         next = p->m_next;
-        if (!next->isBackgroundImageSet() &&
+        if (next && !next->isBackgroundImageSet() &&
             !next->isBackgroundXPositionSet() && !next->isBackgroundYPositionSet() &&
             !next->isBackgroundAttachmentSet() && !next->isBackgroundRepeatSet()) {
             delete next;