+2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
+
+ Unreviewed build fixes.
+
+ * public/include/manifest.php:
+ (Manifest::generate): These should be {} instead of [] when they're empty.
+ * public/v2/data.js:
+ (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
+ * public/v2/manifest.js:
+ (App.Metric.fullName): Fixed the typo.
+ * tests/admin-regenerate-manifest.js: Fixed the test.
+
2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
Commit the erroneously reverted change.
$row = $row['commit_repository'];
$this->manifest = array(
- 'tests' => $this->tests(),
- 'metrics' => $this->metrics(),
- 'all' => $this->platforms($config_table, $platform_table, false),
- 'dashboard' => $this->platforms($config_table, $platform_table, true),
- 'repositories' => $this->repositories($repositories_table, $repositories_with_commit),
- 'builders' => $this->builders(),
- 'bugTrackers' => $this->bug_trackers($repositories_table),
- 'dashboards' => config('dashboards'),
+ 'tests' => (object)$this->tests(),
+ 'metrics' => (object)$this->metrics(),
+ 'all' => (object)$this->platforms($config_table, $platform_table, false),
+ 'dashboard' => (object)$this->platforms($config_table, $platform_table, true),
+ 'repositories' => (object)$this->repositories($repositories_table, $repositories_with_commit),
+ 'builders' => (object)$this->builders(),
+ 'bugTrackers' => (object)$this->bug_trackers($repositories_table),
+ 'dashboards' => (object)config('dashboards'),
);
$this->manifest['elapsedTime'] = (microtime(true) - $start_time) * 1000;
var formattedRevisions = {};
for (var repositoryId in revisions) {
var currentRevision = revisions[repositoryId][0];
- var previousRevision = previousRevisions ? previousRevisions[repositoryId][0] : null;
+ var previousRevision = previousRevisions && previousRevisions[repositoryId] ? previousRevisions[repositoryId][0] : null;
var formatttedRevision = Measurement.formatRevisionRange(currentRevision, previousRevision);
formattedRevisions[repositoryId] = formatttedRevision;
}
}.property('name', 'test'),
fullName: function ()
{
- return this.get('path').join(' \u220b ') /* ∈ */
+ return this.get('path').join(' \u220b ') /* ∋ */
+ ' : ' + this.get('label');
}.property('path', 'label'),
});