Remove obsolete experimental ObjC SPI.

https://bugs.webkit.org/show_bug.cgi?id=169569

Reviewed by Saam Barati.

* API/JSVirtualMachine.mm:
(-[JSVirtualMachine enableSigillCrashAnalyzer]): Deleted.
* API/JSVirtualMachinePrivate.h: Removed.
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/JavaScriptCore/API/JSVirtualMachine.mm b/Source/JavaScriptCore/API/JSVirtualMachine.mm
index 2bbc0430673c83dbe03338839a3352c7758ca230..5145ad9f4adf80de004e2d12b76eaa9e03bb12a1 100644 (file)
--- a/Source/JavaScriptCore/API/JSVirtualMachine.mm
+++ b/Source/JavaScriptCore/API/JSVirtualMachine.mm
@@ -226,11 +226,6 @@ static id getInternalObjcObject(id object)
     }
 }
 
-- (void)enableSigillCrashAnalyzer
-{
-    JSC::enableSigillCrashAnalyzer();
-}
-
 @end
 
 @implementation JSVirtualMachine(Internal)

diff --git a/Source/JavaScriptCore/API/JSVirtualMachinePrivate.h b/Source/JavaScriptCore/API/JSVirtualMachinePrivate.h
deleted file mode 100644 (file)
index 3e5fd42..0000000
--- a/Source/JavaScriptCore/API/JSVirtualMachinePrivate.h
+++ /dev/null
@@ -1,45 +0,0 @@
-/*
- * Copyright (C) 2017 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef JSVirtualMachinePrivate_h
-#define JSVirtualMachinePrivate_h
-
-#if JSC_OBJC_API_ENABLED
-
-@interface JSVirtualMachine(Private)
-
-/*!
- @method
- @abstract Enables SIGILL crash analysis for all JSVirtualMachines.
- @discussion Installs a SIGILL crash handler that will collect additional
- non-user identifying information about the crash site via os_log_info.
- */
-- (void)enableSigillCrashAnalyzer;
-
-@end
-
-#endif
-
-#endif // JSVirtualMachinePrivate_h

diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
index d5adeb91d2a30a8b7db5aa461d9cc550c114b0d3..c54549e2ef68e6e4318c0b3c9dbddeee64763127 100644 (file)
--- a/Source/JavaScriptCore/ChangeLog
+++ b/Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,15 @@
+2017-03-13  Mark Lam  <mark.lam@apple.com>
+
+        Remove obsolete experimental ObjC SPI.
+        https://bugs.webkit.org/show_bug.cgi?id=169569
+
+        Reviewed by Saam Barati.
+
+        * API/JSVirtualMachine.mm:
+        (-[JSVirtualMachine enableSigillCrashAnalyzer]): Deleted.
+        * API/JSVirtualMachinePrivate.h: Removed.
+        * JavaScriptCore.xcodeproj/project.pbxproj:
+
 2017-03-13  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r213856.

diff --git a/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj b/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
index 09200ba20803982f930dc4423e9ae83930a924da..3a7b79b691165ec1cf7b1c0d906eee3d68a93bbd 100644 (file)
--- a/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
+++ b/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
@@ -2384,7 +2384,6 @@
                FE3022D31E3D73A500BAC493 /* SigillCrashAnalyzer.h in Headers */ = {isa = PBXBuildFile; fileRef = FE3022D11E3D739600BAC493 /* SigillCrashAnalyzer.h */; settings = {ATTRIBUTES = (Private, ); }; };
                FE3022D61E42857300BAC493 /* VMInspector.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FE3022D41E42856700BAC493 /* VMInspector.cpp */; };
                FE3022D71E42857300BAC493 /* VMInspector.h in Headers */ = {isa = PBXBuildFile; fileRef = FE3022D51E42856700BAC493 /* VMInspector.h */; };
-               FE3022D91E43C93400BAC493 /* JSVirtualMachinePrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = FE3022D81E43C85500BAC493 /* JSVirtualMachinePrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
                FE318FDF1CAC982700DFCC54 /* ECMAScriptSpecInternalFunctions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FE318FDD1CAC8C5300DFCC54 /* ECMAScriptSpecInternalFunctions.cpp */; };
                FE318FE01CAC982F00DFCC54 /* ECMAScriptSpecInternalFunctions.h in Headers */ = {isa = PBXBuildFile; fileRef = FE318FDE1CAC8C5300DFCC54 /* ECMAScriptSpecInternalFunctions.h */; };
                FE3422121D6B81C30032BE88 /* ThrowScope.h in Headers */ = {isa = PBXBuildFile; fileRef = FE3422111D6B818C0032BE88 /* ThrowScope.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -4974,7 +4973,6 @@
                FE3022D11E3D739600BAC493 /* SigillCrashAnalyzer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SigillCrashAnalyzer.h; sourceTree = "<group>"; };
                FE3022D41E42856700BAC493 /* VMInspector.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = VMInspector.cpp; sourceTree = "<group>"; };
                FE3022D51E42856700BAC493 /* VMInspector.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = VMInspector.h; sourceTree = "<group>"; };
-               FE3022D81E43C85500BAC493 /* JSVirtualMachinePrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSVirtualMachinePrivate.h; sourceTree = "<group>"; };
                FE318FDD1CAC8C5300DFCC54 /* ECMAScriptSpecInternalFunctions.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ECMAScriptSpecInternalFunctions.cpp; sourceTree = "<group>"; };
                FE318FDE1CAC8C5300DFCC54 /* ECMAScriptSpecInternalFunctions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ECMAScriptSpecInternalFunctions.h; sourceTree = "<group>"; };
                FE3422111D6B818C0032BE88 /* ThrowScope.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ThrowScope.h; sourceTree = "<group>"; };
@@ -6035,7 +6033,6 @@
                                86E3C60F167BAB87006D760A /* JSVirtualMachine.h */,
                                86E3C610167BAB87006D760A /* JSVirtualMachine.mm */,
                                86E3C611167BAB87006D760A /* JSVirtualMachineInternal.h */,
-                               FE3022D81E43C85500BAC493 /* JSVirtualMachinePrivate.h */,
                                A7482E37116A697B003B0712 /* JSWeakObjectMapRefInternal.h */,
                                A7482B7A1166CDEA003B0712 /* JSWeakObjectMapRefPrivate.cpp */,
                                A7482B791166CDEA003B0712 /* JSWeakObjectMapRefPrivate.h */,
@@ -8939,7 +8936,6 @@
                                BC18C42C0E16F5CD00B34460 /* JSValueRef.h in Headers */,
                                86E3C615167BABD7006D760A /* JSVirtualMachine.h in Headers */,
                                86E3C61D167BABEE006D760A /* JSVirtualMachineInternal.h in Headers */,
-                               FE3022D91E43C93400BAC493 /* JSVirtualMachinePrivate.h in Headers */,
                                A7CA3AE817DA41AE006538AF /* JSWeakMap.h in Headers */,
                                A7482E93116A7CAD003B0712 /* JSWeakObjectMapRefInternal.h in Headers */,
                                A7482B9311671147003B0712 /* JSWeakObjectMapRefPrivate.h in Headers */,