Fixed: <rdar://problem/3938763> Cannot view Windows Media Player videos (soundtrack...
authorcblu <cblu@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Feb 2005 19:56:18 +0000 (19:56 +0000)
committercblu <cblu@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Feb 2005 19:56:18 +0000 (19:56 +0000)
        Reviewed by hyatt.

        * khtml/html/html_objectimpl.cpp:
        (HTMLObjectElementImpl::attach): set needWidgetUpdate to false right after calling updateWidget because dispatchHTMLEvent can end up calling this method again
        (HTMLObjectElementImpl::recalcStyle): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/html/html_objectimpl.cpp

index 4c2fea3c0fc0434b6fd64f92630284eabf413e5a..dbeb976b947bfee20f8dbde3f30e5892105bd08a 100644 (file)
@@ -1,3 +1,13 @@
+2005-02-03  Chris Blumenberg  <cblu@apple.com>
+
+       Fixed: <rdar://problem/3938763> Cannot view Windows Media Player videos (soundtrack is played twice with delay)
+
+        Reviewed by hyatt.
+
+        * khtml/html/html_objectimpl.cpp:
+        (HTMLObjectElementImpl::attach): set needWidgetUpdate to false right after calling updateWidget because dispatchHTMLEvent can end up calling this method again
+        (HTMLObjectElementImpl::recalcStyle): ditto
+
 2005-02-02  John Sullivan  <sullivan@apple.com>
 
         Reviewed by Chris.
index 1dd8ed5316d508d7cd61344cd4a8c78136de8184..0139e19da1c72d35b69c02a2338df6d1fef1dc64 100644 (file)
@@ -534,8 +534,8 @@ void HTMLObjectElementImpl::attach()
         } else {
             if (needWidgetUpdate) {
                 static_cast<RenderPartObject*>(m_render)->updateWidget();
-                dispatchHTMLEvent(EventImpl::LOAD_EVENT,false,false);
                 needWidgetUpdate = false;
+                dispatchHTMLEvent(EventImpl::LOAD_EVENT,false,false);
             } else {
                 needWidgetUpdate = true;
                 setChanged();
@@ -558,8 +558,8 @@ void HTMLObjectElementImpl::recalcStyle(StyleChange ch)
 {
     if (needWidgetUpdate && m_render && !canRenderImageType(serviceType)) {
         static_cast<RenderPartObject*>(m_render)->updateWidget();
-        dispatchHTMLEvent(EventImpl::LOAD_EVENT,false,false);
         needWidgetUpdate = false;
+        dispatchHTMLEvent(EventImpl::LOAD_EVENT,false,false);
     }
     HTMLElementImpl::recalcStyle(ch);
 }