2011-02-20 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] use 'r' to focus the review select element
        https://bugs.webkit.org/show_bug.cgi?id=54845

        This allows for quick keyboard access to the toolbar items.
        Hit r to get to the review select element. Then you can
        tab to the cq/preview/publish elements.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index 433cbfe9026e0d6312747bdfe22663060b8c42a7..6416d1fea428722dd61a40870894357db4971fa8 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,16 @@
+2011-02-20  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [codereviewtool] use 'r' to focus the review select element
+        https://bugs.webkit.org/show_bug.cgi?id=54845
+
+        This allows for quick keyboard access to the toolbar items.
+        Hit r to get to the review select element. Then you can
+        tab to the cq/preview/publish elements.
+
+        * code-review.js:
+
 2011-02-20  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Adam Barth.

diff --git a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
index afe0dd5c5012786f1728cc7daf893a3fb2c6f103..deab82920ee4bf86736352922b03ed927752b7c1 100644 (file)
--- a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
+++ b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
@@ -451,7 +451,7 @@ div:focus {
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=36"></script>
+<script src="code-review.js?version=37"></script>
 EOF
 
     def self.revisionOrDescription(string)

diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index c3fb45c70cdba1c89a2cc21c0dc14f34794dda20..bbc4a7396d3a3ee8851f2ade4b92ca3d78eaa9dd 100644 (file)
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -76,7 +76,8 @@ var CODE_REVIEW_UNITTEST;
     j: 74,
     k: 75,
     n: 78,
-    p: 80    
+    p: 80,
+    r: 82
   }
 
   function idForLine(number) {
@@ -1413,6 +1414,11 @@ var CODE_REVIEW_UNITTEST;
     var handled = false;
 
     switch (e.keyCode) {
+    case KEY_CODE.r:
+      $('.review select').focus();
+      handled = true;
+      break;
+
     case KEY_CODE.n:
       handled = focusNext(isComment, DIRECTION.FORWARD);
       break;