Reviewed by Adam Barth.
[codereviewtool] use 'r' to focus the review select element
https://bugs.webkit.org/show_bug.cgi?id=54845
This allows for quick keyboard access to the toolbar items.
Hit r to get to the review select element. Then you can
tab to the cq/preview/publish elements.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2011-02-20 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ [codereviewtool] use 'r' to focus the review select element
+ https://bugs.webkit.org/show_bug.cgi?id=54845
+
+ This allows for quick keyboard access to the toolbar items.
+ Hit r to get to the review select element. Then you can
+ tab to the cq/preview/publish elements.
+
+ * code-review.js:
+
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
}
</style>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
-<script src="code-review.js?version=36"></script>
+<script src="code-review.js?version=37"></script>
EOF
def self.revisionOrDescription(string)
j: 74,
k: 75,
n: 78,
- p: 80
+ p: 80,
+ r: 82
}
function idForLine(number) {
var handled = false;
switch (e.keyCode) {
+ case KEY_CODE.r:
+ $('.review select').focus();
+ handled = true;
+ break;
+
case KEY_CODE.n:
handled = focusNext(isComment, DIRECTION.FORWARD);
break;