[BlackBerry] WebPagePrivate::load should not check new window policy
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Feb 2013 19:09:07 +0000 (19:09 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Feb 2013 19:09:07 +0000 (19:09 +0000)
https://bugs.webkit.org/show_bug.cgi?id=110403

Patch by Andrew Lo <anlo@rim.com> on 2013-02-21
Reviewed by Rob Buis.

Based on my understanding of changeset 135952, we should
not check the new window policy in WebPagePrivate::load.

None of the other ports seem to do this, except for plugins.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/blackberry/Api/WebPage.cpp
Source/WebKit/blackberry/ChangeLog

index 36ba6e5d2a3b80294b951fcd8cfe2cf9ba9bdbd4..bf29c6a8bf9419a241ed2e3ad954be1bd5623a56 100644 (file)
@@ -705,10 +705,7 @@ void WebPagePrivate::load(const BlackBerry::Platform::String& url, const BlackBe
 
     request.setSuggestedSaveName(suggestedSaveName);
 
-    FrameLoadRequest frameRequest(m_mainFrame, request);
-    frameRequest.setFrameName("");
-    frameRequest.setShouldCheckNewWindowPolicy(true);
-    m_mainFrame->loader()->load(frameRequest);
+    m_mainFrame->loader()->load(FrameLoadRequest(m_mainFrame, request));
 }
 
 void WebPage::load(const BlackBerry::Platform::String& url, const BlackBerry::Platform::String& networkToken, bool isInitial)
index f9b84312b5fcc311d884a1e8ea4574233d156bd0..95dbf8d2e7a427852da14ef8c11d0ef8f50cb400 100644 (file)
@@ -1,3 +1,18 @@
+2013-02-21  Andrew Lo  <anlo@rim.com>
+
+        [BlackBerry] WebPagePrivate::load should not check new window policy
+        https://bugs.webkit.org/show_bug.cgi?id=110403
+
+        Reviewed by Rob Buis.
+
+        Based on my understanding of changeset 135952, we should
+        not check the new window policy in WebPagePrivate::load.
+
+        None of the other ports seem to do this, except for plugins.
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::load):
+
 2013-02-21  Alberto Garcia  <albgarcia@rim.com>
 
         [BlackBerry] BackingStore: replace instrument{Begin,Cancel}Frame with did{Begin,Cancel}Frame