New perf dashboard doesn't preserve the number of days when clicking on a dashboard...

https://bugs.webkit.org/show_bug.cgi?id=141280

Reviewed by Chris Dumez.

Fixed the bug by passing in "since" as a query parameter to the charts page.

Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.

* public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
* public/v2/app.js:
(App.IndexController): Changed the default number of days from one month to one week.
(App.IndexController._sharedDomainChanged): Set "since" property on the controller.
* public/v2/index.html: Pass in "since" property on the controller as a query parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 12388031d2ff02269fafd56cadbd7330b1fb047c..edec13c8915089dd6a76929bc9a08e19c72bf474 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,20 @@
+2015-02-04  Ryosuke Niwa  <rniwa@webkit.org>
+
+        New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
+        https://bugs.webkit.org/show_bug.cgi?id=141280
+
+        Reviewed by Chris Dumez.
+
+        Fixed the bug by passing in "since" as a query parameter to the charts page.
+
+        Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
+
+        * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
+        * public/v2/app.js:
+        (App.IndexController): Changed the default number of days from one month to one week.
+        (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
+        * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
+
 2015-02-04  Ryosuke Niwa  <rniwa@webkit.org>
 
         New perf dashboard erroneously clears zoom when poping history items

diff --git a/Websites/perf.webkit.org/public/v2/app.css b/Websites/perf.webkit.org/public/v2/app.css
index 45fa890ef11a94a863b587857b20b84bfdf0ab3b..51cb5c85852e7cba24629d496da0bde4fa8cf52a 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/app.css
+++ b/Websites/perf.webkit.org/public/v2/app.css
@@ -403,13 +403,19 @@ table.dashboard tbody td .chart {
 }
 
 table.dashboard tbody td .chart,
-table.dashboard tbody td .failure,
 table.dashboard tbody td .progress {
     display: inline-block;
     width: 100%;
     height: 12rem;
     line-height: 12rem;
-    vertical-align: center;
+    vertical-align: middle;
+}
+
+table.dashboard tbody td .failure {
+    display: table-cell;
+    width: 100%;
+    height: 12rem;
+    vertical-align: middle;
 }
 
 #analysis-tasks,

diff --git a/Websites/perf.webkit.org/public/v2/app.js b/Websites/perf.webkit.org/public/v2/app.js
index 0ed6dac5588768c10586d111ae042881c511c431..6d6d803c5fa3c3c7c0203d0fbaaebdfc58d4bc44 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/app.js
+++ b/Websites/perf.webkit.org/public/v2/app.js
@@ -59,7 +59,7 @@ App.IndexController = Ember.Controller.extend({
     _previousGrid: {},
     headerColumns: [],
     rows: [],
-    numberOfDays: 30,
+    numberOfDays: 7,
     editMode: false,
 
     gridChanged: function ()
@@ -119,6 +119,7 @@ App.IndexController = Ember.Controller.extend({
         numberOfDays = parseInt(numberOfDays);
         var present = Date.now();
         var past = present - numberOfDays * 24 * 3600 * 1000;
+        this.set('since', past);
         this.set('sharedDomain', [past, present]);
     }.observes('numberOfDays').on('init'),
 

diff --git a/Websites/perf.webkit.org/public/v2/index.html b/Websites/perf.webkit.org/public/v2/index.html
index a092852890a8bfa4dd0cc29dc5904b91bc6c138d..0147cf7fe29fce7a978082de96fdaf791bd65ae7 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/index.html
+++ b/Websites/perf.webkit.org/public/v2/index.html
@@ -78,7 +78,7 @@
                                 {{/if}}
                             {{else}}
                                 {{#if chartData}}
-                                    {{#link-to 'charts' (query-params paneList=paneList)}}
+                                    {{#link-to 'charts' (query-params paneList=paneList since=controller.since)}}
                                     {{interactive-chart
                                         chartData=chartData
                                         domain=controller.sharedDomain