Web Inspector: REGRESSION detached dom nodes aren't highlighted
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Feb 2012 07:54:53 +0000 (07:54 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Feb 2012 07:54:53 +0000 (07:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=77829

This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/HeapSnapshot.js

index 90aa4df1ea3dc5b67ab06c5666dc80513531d38f..0c30f68741cb3e9f5b028404976b33902253eb22 100644 (file)
@@ -1,3 +1,16 @@
+2012-02-05  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: REGRESSION detached dom nodes aren't highlighted
+        https://bugs.webkit.org/show_bug.cgi?id=77829
+
+        This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/HeapSnapshot.js:
+        (WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
+        (WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
+
 2012-02-05  Ilya Tikhonovsky  <loislo@chromium.org>
 
         Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
index 4a57ad7e61c794995a7cef0ba8b69847d8e8ce05..4d06dbd876e91977d3b5962312a21e841f744989 100644 (file)
@@ -576,9 +576,9 @@ WebInspector.HeapSnapshotNode.prototype = {
         return this.name.substr(0, 9) === "DOMWindow";
     },
 
-    get isNativeRoot()
+    get isDetachedDOMTreesRoot()
     {
-        return this.name === "(Native objects)";
+        return this.name === "(Detached DOM trees)";
     },
 
     get isDetachedDOMTree()
@@ -1087,19 +1087,19 @@ WebInspector.HeapSnapshot.prototype = {
     _markDetachedDOMTreeNodes: function()
     {
         var flag = this._nodeFlags.detachedDOMTreeNode;
-        var nativeRoot;
+        var detachedDOMTreesRoot;
         for (var iter = this.rootNode.edges; iter.hasNext(); iter.next()) {
             var node = iter.edge.node;
-            if (node.isNativeRoot) {
-                nativeRoot = node;
+            if (node.isDetachedDOMTreesRoot) {
+                detachedDOMTreesRoot = node;
                 break;
             }
         }
 
-        if (!nativeRoot)
+        if (!detachedDOMTreesRoot)
             return;
 
-        for (var iter = nativeRoot.edges; iter.hasNext(); iter.next()) {
+        for (var iter = detachedDOMTreesRoot.edges; iter.hasNext(); iter.next()) {
             var node = iter.edge.node;
             if (node.isDetachedDOMTree) {
                 for (var edgesIter = node.edges; edgesIter.hasNext(); edgesIter.next())