Update FULLSCREEN_API feature defines.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Dec 2017 21:10:12 +0000 (21:10 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Dec 2017 21:10:12 +0000 (21:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=181015

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-12-21
Reviewed by Tim Horton.

Change enabled iphone sdk for FULLSCREEN_API.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 files changed:
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
Source/WebKit/ChangeLog
Source/WebKit/Configurations/FeatureDefines.xcconfig
Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
Tools/ChangeLog
Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig

index 55e305b4702056dbc5bbe997f9ee94364d5d0faa..bc08b9ac6b5bfdd8dd7398f2d866d7d9e43f02d8 100644 (file)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <jeremyj@apple.com>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
 
         [JSC] Do not check isValid() in op_new_regexp
index 0ade509244508ec8a4ada609d94a989959f638e0..9e2a6f2ed5285c6292a16ea902eb2010a3b45742 100644 (file)
@@ -64,6 +64,15 @@ ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_ = $(ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO);
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@ ENABLE_DASHBOARD_SUPPORT[sdk=macosx*] = ENABLE_DASHBOARD_SUPPORT;
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;
index a4c9b6b3a66bb42651ed96679e73333ec2bff8f6..a897a3c48a8e6ac1e35b431c14c0016c1b757f1d 100644 (file)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <jeremyj@apple.com>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  Chris Dumez  <cdumez@apple.com>
 
         ononline, onoffline and navigator.onLine don't work if Parallels or VMWare is installed
index 0ade509244508ec8a4ada609d94a989959f638e0..9e2a6f2ed5285c6292a16ea902eb2010a3b45742 100644 (file)
@@ -64,6 +64,15 @@ ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_ = $(ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO);
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@ ENABLE_DASHBOARD_SUPPORT[sdk=macosx*] = ENABLE_DASHBOARD_SUPPORT;
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;
index e70c4ad79ade91debef9d140f6a10d99b9bcc2c3..9c7fd3df11f7205ebf0b8bd8e8ed673e6b46552c 100644 (file)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <jeremyj@apple.com>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  Brent Fulgham  <bfulgham@apple.com>
 
         Adopt new secure coding APIs in WebCore
index 0ade509244508ec8a4ada609d94a989959f638e0..9e2a6f2ed5285c6292a16ea902eb2010a3b45742 100644 (file)
@@ -64,6 +64,15 @@ ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_ = $(ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO);
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@ ENABLE_DASHBOARD_SUPPORT[sdk=macosx*] = ENABLE_DASHBOARD_SUPPORT;
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;
index 78d53e00d1561aa6d47b29abafaaf5142b07ece4..4df8fffdceb80135fa044b4139efa251e9cc1976 100644 (file)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <jeremyj@apple.com>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  John Wilander  <wilander@apple.com>
 
         Storage Access API: Make DocumentLoader::willSendRequest() and WebFrameLoaderClient::detachedFromParent2() tell the network process to get rid of any sub frame access entries
index 0ade509244508ec8a4ada609d94a989959f638e0..9e2a6f2ed5285c6292a16ea902eb2010a3b45742 100644 (file)
@@ -64,6 +64,15 @@ ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_ = $(ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO);
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@ ENABLE_DASHBOARD_SUPPORT[sdk=macosx*] = ENABLE_DASHBOARD_SUPPORT;
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;
index af19647fbea82d7ca9e9583728ddc01c15b0dcf6..e4fc0db04d311823f496e311ca98bf8ec9d563da 100644 (file)
@@ -4866,6 +4866,7 @@ static inline WebKit::FindOptions toFindOptions(_WKFindOptions wkFindOptions)
 
 #if PLATFORM(IOS)
 
+#if ENABLE(FULLSCREEN_API)
 - (void)removeFromSuperview
 {
     [super removeFromSuperview];
@@ -4873,6 +4874,7 @@ static inline WebKit::FindOptions toFindOptions(_WKFindOptions wkFindOptions)
     if ([_fullScreenWindowController isFullScreen])
         [_fullScreenWindowController webViewDidRemoveFromSuperviewWhileInFullscreen];
 }
+#endif
 
 - (CGSize)_minimumLayoutSizeOverride
 {
index 2248cd6e2b5b0be902ac5c7ff87bf83ddc27a54c..f74f6f5c83b574614ec776a694ef99d4e0a0ba3a 100644 (file)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <jeremyj@apple.com>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  Jer Noble  <jer.noble@apple.com>
 
         Add initial DOM support for Media Capabilities
index 0ade509244508ec8a4ada609d94a989959f638e0..9e2a6f2ed5285c6292a16ea902eb2010a3b45742 100644 (file)
@@ -64,6 +64,15 @@ ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_ = $(ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO);
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@ ENABLE_DASHBOARD_SUPPORT[sdk=macosx*] = ENABLE_DASHBOARD_SUPPORT;
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;
index b2be822f0c4cc42cf183d83cfa68636b29e5e7d9..bcbcd9326ce6e87a2ace6a7d64ad9bb8cff6c31f 100644 (file)
@@ -1,3 +1,14 @@
+2017-12-21  Jeremy Jones  <jeremyj@apple.com>
+
+        Update FULLSCREEN_API feature defines.
+        https://bugs.webkit.org/show_bug.cgi?id=181015
+
+        Reviewed by Tim Horton.
+
+        Change enabled iphone sdk for FULLSCREEN_API.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
 2017-12-21  Don Olmstead  <don.olmstead@sony.com>
 
         [AppleWin] Auxiliary libraries should be updated within build-webkit
index 0ade509244508ec8a4ada609d94a989959f638e0..9e2a6f2ed5285c6292a16ea902eb2010a3b45742 100644 (file)
@@ -64,6 +64,15 @@ ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_ = $(ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO);
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_NO = ENABLE_APPLE_PAY_SESSION_V3;
 ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
 
+ENABLE_FULLSCREEN_API[sdk=iphone*] = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
+ENABLE_FULLSCREEN_API_iphoneos = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API_iphonesimulator = ENABLE_FULLSCREEN_API;
+ENABLE_FULLSCREEN_API[sdk=iphoneos10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator10*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphoneos11*] = ;
+ENABLE_FULLSCREEN_API[sdk=iphonesimulator11*] = ;
+ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
+
 ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
@@ -88,8 +97,6 @@ ENABLE_DASHBOARD_SUPPORT[sdk=macosx*] = ENABLE_DASHBOARD_SUPPORT;
 ENABLE_DATALIST_ELEMENT = ;
 ENABLE_DEVICE_ORIENTATION[sdk=iphone*] = ENABLE_DEVICE_ORIENTATION;
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
-ENABLE_FULLSCREEN_API[sdk=iphone*] = ENABLE_FULLSCREEN_API;
-ENABLE_FULLSCREEN_API[sdk=macosx*] = ENABLE_FULLSCREEN_API;
 ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN[sdk=macosx*] = ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN;
 ENABLE_GAMEPAD = ENABLE_GAMEPAD;
 ENABLE_GAMEPAD[sdk=watch*] = ;