Reviewed by Maciej.

        - fixed <rdar://problem/4029741> REGRESSION (188-189): <input type=text> are cleared when you hide/show them

        * khtml/html/html_formimpl.h: Added detach functions for both input and text area elements, since
        both have m_valueMatchesRenderer flags.
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLInputElementImpl::detach): Set m_valueMatchesRenderer to false, since the renderer is going away.
        (DOM::HTMLTextAreaElementImpl::detach): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 5db1e005ba3e20b788965524ff01c8cfba407301..bcb22b55e1aadf9a406ad7ded2838e90af08f141 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,15 @@
+2005-03-02  Darin Adler  <darin@apple.com>
+
+        Reviewed by Maciej.
+
+        - fixed <rdar://problem/4029741> REGRESSION (188-189): <input type=text> are cleared when you hide/show them
+
+        * khtml/html/html_formimpl.h: Added detach functions for both input and text area elements, since
+        both have m_valueMatchesRenderer flags.
+        * khtml/html/html_formimpl.cpp:
+        (DOM::HTMLInputElementImpl::detach): Set m_valueMatchesRenderer to false, since the renderer is going away.
+        (DOM::HTMLTextAreaElementImpl::detach): Ditto.
+
 2005-03-02  Ken Kocienda  <kocienda@apple.com>
 
         Reviewed by Hyatt

diff --git a/WebCore/khtml/html/html_formimpl.cpp b/WebCore/khtml/html/html_formimpl.cpp
index b8a0ee7f5cb3c6749b8d30132340405188e02874..82fb5a550ed59666fd3661c16774c5a932b9334d 100644 (file)
--- a/WebCore/khtml/html/html_formimpl.cpp
+++ b/WebCore/khtml/html/html_formimpl.cpp
@@ -1727,6 +1727,12 @@ void HTMLInputElementImpl::attach()
 #endif
 }
 
+void HTMLInputElementImpl::detach()
+{
+    HTMLGenericFormElementImpl::detach();
+    m_valueMatchesRenderer = false;
+}
+
 DOMString HTMLInputElementImpl::altText() const
 {
     // http://www.w3.org/TR/1998/REC-html40-19980424/appendix/notes.html#altgen
@@ -3151,6 +3157,12 @@ void HTMLTextAreaElementImpl::accessKeyAction()
     focus();
 }
 
+void HTMLTextAreaElementImpl::detach()
+{
+    HTMLGenericFormElementImpl::detach();
+    m_valueMatchesRenderer = false;
+}
+
 // -------------------------------------------------------------------------
 
 HTMLIsIndexElementImpl::HTMLIsIndexElementImpl(DocumentPtr *doc, HTMLFormElementImpl *f)

diff --git a/WebCore/khtml/html/html_formimpl.h b/WebCore/khtml/html/html_formimpl.h
index 841ade069ec27fdb138f551b9ac3258fb4abc33c..429839608e53ef99af4210d52ba2ec8d20fc3e34 100644 (file)
--- a/WebCore/khtml/html/html_formimpl.h
+++ b/WebCore/khtml/html/html_formimpl.h
@@ -339,6 +339,7 @@ public:
     virtual void attach();
     virtual bool rendererIsNeeded(khtml::RenderStyle *);
     virtual khtml::RenderObject *createRenderer(RenderArena *, khtml::RenderStyle *);
+    virtual void detach();
     virtual bool appendFormData(FormDataList&, bool);
 
     virtual bool isSuccessfulSubmitButton() const;
@@ -635,6 +636,7 @@ public:
     virtual void childrenChanged();
     virtual void parseHTMLAttribute(HTMLAttributeImpl *attr);
     virtual khtml::RenderObject *createRenderer(RenderArena *, khtml::RenderStyle *);
+    virtual void detach();
     virtual bool appendFormData(FormDataList&, bool);
     virtual void reset();
     DOMString value();