2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Mar 2011 19:49:09 +0000 (19:49 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Mar 2011 19:49:09 +0000 (19:49 +0000)
        Reviewed by Yury Semikhatsky.

        Web Inspector: rename console agent events.
        https://bugs.webkit.org/show_bug.cgi?id=56646

        addConsoleMessage -> consoleMessage
        updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
        updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate

        WebCore:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        (WebCore::ConsoleMessage::updateRepeatCountInConsole):
        * inspector/Inspector.json:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessage):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageExpiredCountUpdate):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdate):

LayoutTests:
        * inspector/protocol/console-agent-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/inspector/protocol/console-agent-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/inspector/ConsoleMessage.cpp
Source/WebCore/inspector/Inspector.json
Source/WebCore/inspector/InspectorConsoleAgent.cpp
Source/WebCore/inspector/front-end/ConsoleView.js

index 9bcbb791bbfdf7f6b196ec19a1a25104f3800dd8..43507431b541ea2e3111c831a90f4de099ac5f14 100644 (file)
@@ -1,3 +1,16 @@
+2011-03-18  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: rename console agent events.
+        https://bugs.webkit.org/show_bug.cgi?id=56646
+
+        addConsoleMessage -> consoleMessage
+        updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
+        updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate
+
+        * inspector/protocol/console-agent-expected.txt:
+
 2011-03-18  Stephen White  <senorblanco@chromium.org>
 
         Unreviewed; new test baselines.
index 3017b40800b25b2154b7527fbf0361763f9293a4..ee5356be06ea2f0714b8c999dee04cb6e8e6453c 100644 (file)
@@ -59,11 +59,11 @@ request:
     }
 }
 
-event ConsoleAgent.addConsoleMessage
+event ConsoleAgent.consoleMessage
 {
     type : "event"
     domain : "Console"
-    event : "addConsoleMessage"
+    event : "consoleMessage"
     body : {
         messageObj : {
             source : 3
@@ -84,11 +84,11 @@ event ConsoleAgent.addConsoleMessage
     }
 }
 
-event ConsoleAgent.updateConsoleMessageRepeatCount
+event ConsoleAgent.consoleMessageRepeatCountUpdate
 {
     type : "event"
     domain : "Console"
-    event : "updateConsoleMessageRepeatCount"
+    event : "consoleMessageRepeatCountUpdate"
     body : {
         count : 2
     }
@@ -192,9 +192,9 @@ Coverage for ConsoleAgent
     clearConsoleMessages : "checked"
     setMonitoringXHREnabled : "checked"
     addInspectedNode : "checked"
-    addConsoleMessage : "checked"
-    updateConsoleMessageExpiredCount : "not checked"
-    updateConsoleMessageRepeatCount : "checked"
+    consoleMessage : "checked"
+    consoleMessageExpiredCountUpdate : "not checked"
+    consoleMessageRepeatCountUpdate : "checked"
     consoleMessagesCleared : "checked"
 }
 
index e3f1d21b43544f7f878ef8fdc63c539aed0cc6f2..15eefc1dedf73fcf1955b7262840df70576e9dcf 100644 (file)
@@ -1,3 +1,25 @@
+2011-03-18  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: rename console agent events.
+        https://bugs.webkit.org/show_bug.cgi?id=56646
+
+        addConsoleMessage -> consoleMessage
+        updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
+        updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate
+
+        * inspector/ConsoleMessage.cpp:
+        (WebCore::ConsoleMessage::addToFrontend):
+        (WebCore::ConsoleMessage::updateRepeatCountInConsole):
+        * inspector/Inspector.json:
+        * inspector/InspectorConsoleAgent.cpp:
+        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessage):
+        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageExpiredCountUpdate):
+        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdate):
+
 2011-03-18  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r81487.
index fdbf61daf9e760413972ac656cebaf991bc9b906..5f5b4fbb5d72601f5c1359de49ce2e31b2a2af71 100644 (file)
@@ -115,12 +115,12 @@ void ConsoleMessage::addToFrontend(InspectorFrontend::Console* frontend, Injecte
     }
     if (m_callStack)
         jsonObj->setArray("stackTrace", m_callStack->buildInspectorArray());
-    frontend->addConsoleMessage(jsonObj);
+    frontend->consoleMessage(jsonObj);
 }
 
 void ConsoleMessage::updateRepeatCountInConsole(InspectorFrontend::Console* frontend)
 {
-    frontend->updateConsoleMessageRepeatCount(m_repeatCount);
+    frontend->consoleMessageRepeatCountUpdate(m_repeatCount);
 }
 
 bool ConsoleMessage::isEqual(ConsoleMessage* msg) const
index 7ae562ac6dc9f360c6c8d8c2e9ea0779b4c183bf..bc7c00ba5845742b6439801ecafddb7f31860d6f 100644 (file)
         ],
         "events": [
             {
-                "name": "addConsoleMessage",
+                "name": "consoleMessage",
                 "parameters": [
                     { "name": "messageObj", "$ref": "ConsoleMessage" }
                 ]
             },
             {
-                "name": "updateConsoleMessageExpiredCount",
+                "name": "consoleMessageExpiredCountUpdate",
                 "parameters": [
                     { "name": "count", "type": "unsigned" }
                 ]
             },
             {
-                "name": "updateConsoleMessageRepeatCount",
+                "name": "consoleMessageRepeatCountUpdate",
                 "parameters": [
                     { "name": "count", "type": "unsigned" }
                 ]
index 11fd80965b0d4490fa363c4f60cb91cad99d0fad..9fbd5fc74c2c0edcda1e6242fa47036f478cbbcd 100644 (file)
@@ -233,7 +233,7 @@ void InspectorConsoleAgent::setConsoleMessagesEnabled(bool enabled)
         return;
 
     if (m_expiredConsoleMessageCount)
-        m_frontend->updateConsoleMessageExpiredCount(m_expiredConsoleMessageCount);
+        m_frontend->consoleMessageExpiredCountUpdate(m_expiredConsoleMessageCount);
     unsigned messageCount = m_consoleMessages.size();
     for (unsigned i = 0; i < messageCount; ++i)
         m_consoleMessages[i]->addToFrontend(m_frontend, m_injectedScriptManager);
index 718315f2f67212c4b073025e8f26d501ca0e7e80..4bb9fd5b24d24d9d9b542b7492a63ee3e5e80468 100644 (file)
@@ -105,7 +105,7 @@ WebInspector.ConsoleView.prototype = {
     _registerConsoleDomainDispatcher: function() {
         var console = this;
         var dispatcher = {
-            addConsoleMessage: function(payload)
+            consoleMessage: function(payload)
             {
                 var consoleMessage = new WebInspector.ConsoleMessage(
                     payload.source,
@@ -121,13 +121,13 @@ WebInspector.ConsoleView.prototype = {
                 console.addMessage(consoleMessage);
             },
 
-            updateConsoleMessageExpiredCount: function(count)
+            consoleMessageExpiredCountUpdate: function(count)
             {
                 var message = String.sprintf(WebInspector.UIString("%d console messages are not shown."), count);
                 console.addMessage(WebInspector.ConsoleMessage.createTextMessage(message, WebInspector.ConsoleMessage.MessageLevel.Warning));
             },
 
-            updateConsoleMessageRepeatCount: function(count)
+            consoleMessageRepeatCountUpdate: function(count)
             {
                 var msg = console.previousMessage;
                 var prevRepeatCount = msg.totalRepeatCount;