Reviewed by Adam.
Bug 10923: Frame scroll layout test failures on the buildbot
http://bugzilla.opendarwin.org/show_bug.cgi?id=10923
Made this test call layoutTestController.dumpChildFrameScrollPositions().
* fast/overflow/scrollRevealButton-expected.txt:
* fast/overflow/scrollRevealButton.html:
WebKitTools:
Reviewed by Adam.
Bug 10923: Frame scroll layout test failures on the buildbot
http://bugzilla.opendarwin.org/show_bug.cgi?id=10923
Added a new method that will toggle on the recursive dump of
child frame scroll positions.
* DumpRenderTree/DumpRenderTree.m:
(dumpFrameScrollPosition):
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(-[LayoutTestController dumpChildFrameScrollPositions]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2006-09-21 Timothy Hatcher <timothy@apple.com>
+
+ Reviewed by Adam.
+
+ Bug 10923: Frame scroll layout test failures on the buildbot
+ http://bugzilla.opendarwin.org/show_bug.cgi?id=10923
+
+ Made this test call layoutTestController.dumpChildFrameScrollPositions().
+
+ * fast/overflow/scrollRevealButton-expected.txt:
+ * fast/overflow/scrollRevealButton.html:
+
2006-09-20 Justin Garcia <justin.garcia@apple.com>
Reviewed by john
RenderText {#text} at (0,0) size 339x18
text run at (0,0) width 339: "This test should scroll recursively to reveal the button."
RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
RenderBlock {DIV} at (0,18) size 769x500
RenderBlock (anonymous) at (0,518) size 769x150
RenderPartObject {IFRAME} at (0,0) size 300x150
<html>This test should scroll recursively to reveal the button.
<body onload="document.getElementById('fr').contentDocument.getElementById('bt').focus();">
+<script>if(layoutTestController) layoutTestController.dumpChildFrameScrollPositions();</script>
<div style="height:500px"></div>
<iframe src="resources/scrollButton1.html" id="fr"></iframe>
<div style="height:500px"></div>
+2006-09-21 Timothy Hatcher <timothy@apple.com>
+
+ Reviewed by Adam.
+
+ Bug 10923: Frame scroll layout test failures on the buildbot
+ http://bugzilla.opendarwin.org/show_bug.cgi?id=10923
+
+ Added a new method that will toggle on the recursive dump of
+ child frame scroll positions.
+
+ * DumpRenderTree/DumpRenderTree.m:
+ (dumpFrameScrollPosition):
+ (+[LayoutTestController isSelectorExcludedFromWebScript:]):
+ (-[LayoutTestController dumpChildFrameScrollPositions]):
+
2006-09-19 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by eseidel. Landed by eseidel.
static BOOL dumpSelectionRect;
static BOOL dumpTitleChanges;
static BOOL dumpBackForwardList;
+static BOOL dumpChildFrameScrollPositions;
static int dumpPixels = NO;
static int dumpAllPixels = NO;
static BOOL readFromWindow = NO;
printf("frame '%s' ", [[f name] UTF8String]);
printf("scrolled to %.f,%.f\n", scrollPosition.x, scrollPosition.y);
}
- NSArray *kids = [f childFrames];
- if (kids)
- for (unsigned i = 0; i < [kids count]; i++)
- dumpFrameScrollPosition([kids objectAtIndex:i]);
+
+ if (dumpChildFrameScrollPositions) {
+ NSArray *kids = [f childFrames];
+ if (kids)
+ for (unsigned i = 0; i < [kids count]; i++)
+ dumpFrameScrollPosition([kids objectAtIndex:i]);
+ }
}
static void dump(void)
|| aSelector == @selector(dumpAsText)
|| aSelector == @selector(dumpTitleChanges)
|| aSelector == @selector(dumpBackForwardList)
+ || aSelector == @selector(dumpChildFrameScrollPositions)
|| aSelector == @selector(setWindowIsKey:)
|| aSelector == @selector(setMainFrameIsFirstResponder:)
|| aSelector == @selector(dumpSelectionRect)
dumpBackForwardList = YES;
}
+- (void)dumpChildFrameScrollPositions
+{
+ dumpChildFrameScrollPositions = YES;
+}
+
- (void)setWindowIsKey:(BOOL)flag
{
windowIsKey = flag;