Reviewed by Maciej.

        - fixed <rdar://problem/3528339> Turn on full keyboard access shows
        invisible <input> elements

        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLGenericFormElementImpl::isFocusable):
        reject elements that have zero width or height, even if they aren't hidden

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 444777b1d6c41a21e465656c3b2b86cfad9f9ec6..2d25ef0ce811e60709216101603788b5e8a190e1 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,14 @@
+2004-09-24  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Maciej.
+        
+        - fixed <rdar://problem/3528339> Turn on full keyboard access shows 
+        invisible <input> elements
+
+        * khtml/html/html_formimpl.cpp:
+        (DOM::HTMLGenericFormElementImpl::isFocusable):
+        reject elements that have zero width or height, even if they aren't hidden
+
 2004-09-24  Maciej Stachowiak  <mjs@apple.com>
 
        - fixed deployment build

diff --git a/WebCore/khtml/html/html_formimpl.cpp b/WebCore/khtml/html/html_formimpl.cpp
index 04df46f6bb86faa26bcd65f99605f87174241b53..9e922ed331d1d953af56237ca69c8e82ef6fc4e2 100644 (file)
--- a/WebCore/khtml/html/html_formimpl.cpp
+++ b/WebCore/khtml/html/html_formimpl.cpp
@@ -892,7 +892,7 @@ void HTMLGenericFormElementImpl::recalcStyle( StyleChange ch )
 
 bool HTMLGenericFormElementImpl::isFocusable() const
 {
-    if (!m_render || (m_render->style() && m_render->style()->visibility() != VISIBLE))
+    if (!m_render || (m_render->style() && m_render->style()->visibility() != VISIBLE) || m_render->width() == 0 || m_render->height() == 0)
         return false;
     return true;
 }