Vicki gave me special dispensation to check this in though the tree is closed.

        Reviewed by Chris.

        - fixed <rdar://problem/3903990> can't tab to all items on www.google.com any more (other pages too?)

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::nextKeyViewInFrameHierarchy):
        when checking whether we moved the focus to another view, make sure we didn't "move" it to
        our documentView, because that's no move at all.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 794d646d24347c9449329a7682d7c1428c987b5e..4f4b94b90f72ea48a0ea19610613e6e8526f41b5 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,14 @@
+2004-12-03  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Chris.
+        
+        - fixed <rdar://problem/3903990> can't tab to all items on www.google.com any more (other pages too?)
+
+        * kwq/KWQKHTMLPart.mm:
+        (KWQKHTMLPart::nextKeyViewInFrameHierarchy):
+        when checking whether we moved the focus to another view, make sure we didn't "move" it to
+        our documentView, because that's no move at all.
+
 2004-12-03  Darin Adler  <darin@apple.com>
 
         Reviewed by Vicki.

diff --git a/WebCore/kwq/KWQKHTMLPart.mm b/WebCore/kwq/KWQKHTMLPart.mm
index bce69edae16c47af7c9d3276dbbc522bde31c507..8838c75dca9f12c5784b5cbbfe54dd5352a6d07e 100644 (file)
--- a/WebCore/kwq/KWQKHTMLPart.mm
+++ b/WebCore/kwq/KWQKHTMLPart.mm
@@ -1227,8 +1227,8 @@ NSView *KWQKHTMLPart::nextKeyViewInFrameHierarchy(NodeImpl *node, KWQSelectionDi
         }
     }
     
-    if (next) {
-        // remove focus from currently focused node if we're giving focus to another view
+    // remove focus from currently focused node if we're giving focus to another view
+    if (next && (next != [_bridge documentView])) {
         DocumentImpl *doc = xmlDocImpl();
         if (doc) {
             doc->setFocusNode(0);